Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Remove unused spec-to-console package #193426

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 19, 2024

Closes #163333

Summary

It was superseded by generate-console-definitions.

For maintainers

@pquentin pquentin added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Sep 19, 2024
@pquentin pquentin requested a review from a team as a code owner September 19, 2024 13:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@pquentin pquentin changed the title Remove unused spec-to-console package [Console] Remove unused spec-to-console package Sep 19, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 19, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Changes lgtm.

@ElenaStoeva
Copy link
Contributor

Hey @pquentin, is there a reason why this PR is not merged yet?

@pquentin
Copy link
Member Author

@ElenaStoeva No specific reason, I think the CI was failing and I did not investigate further.

@ElenaStoeva ElenaStoeva added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 15, 2024
@ElenaStoeva ElenaStoeva enabled auto-merge (squash) October 15, 2024 13:16
@ElenaStoeva ElenaStoeva merged commit 920d782 into elastic:main Oct 15, 2024
52 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11348900680

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 193426

Questions ?

Please refer to the Backport tool documentation

@ElenaStoeva ElenaStoeva added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console] Remove the old script for definitions generation
5 participants