Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inference] improve simulated function calling instructions #193414

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Sep 19, 2024

Summary

(and do it also for o11y)

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Team:AI Infra AppEx AI Infrastructure Team v9.0.0 v8.16.0 labels Sep 19, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review September 19, 2024 17:49
@pgayvallet pgayvallet requested review from a team as code owners September 19, 2024 17:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

@pgayvallet pgayvallet force-pushed the kbn-xxx-improve-SFC-instructions branch from a047cbe to 669993d Compare September 19, 2024 18:29
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Sep 19, 2024
@pgayvallet pgayvallet removed the request for review from a team September 19, 2024 18:29
@pgayvallet pgayvallet enabled auto-merge (squash) September 19, 2024 19:26
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 19, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 0606e2b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193414-0606e2b8f7e6

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / Configuration button renders the tooltip correctly when hovering the button
  • [job] [logs] Jest Tests #8 / FilterPopover renders button label correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit a940293 into elastic:main Sep 19, 2024
26 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
…193414)

## Summary

(and do it also for o11y)

(cherry picked from commit a940293)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Synthetics] waterfall chart - handle cached resources (#193089)
- [Reporting] update puppeteer to version 23.3.1 (#192345)
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 193414

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2024
…93414) (#193484)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[inference] improve simulated function calling instructions
(#193414)](#193414)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T20:22:44Z","message":"[inference]
improve simulated function calling instructions (#193414)\n\n##
Summary\r\n\r\n(and do it also for
o11y)","sha":"a9402939f378bfd9ba6136b9bba687430c64ca32","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:Obs
AI Assistant","ci:project-deploy-observability","v8.16.0","Team:AI
Infra"],"title":"[inference] improve simulated function calling
instructions","number":193414,"url":"https://github.com/elastic/kibana/pull/193414","mergeCommit":{"message":"[inference]
improve simulated function calling instructions (#193414)\n\n##
Summary\r\n\r\n(and do it also for
o11y)","sha":"a9402939f378bfd9ba6136b9bba687430c64ca32"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193414","number":193414,"mergeCommit":{"message":"[inference]
improve simulated function calling instructions (#193414)\n\n##
Summary\r\n\r\n(and do it also for
o11y)","sha":"a9402939f378bfd9ba6136b9bba687430c64ca32"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team Team:Obs AI Assistant Observability AI Assistant v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants