-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-7781 - switching bk pipeline to gpctl promote after synthetics #193411
CP-7781 - switching bk pipeline to gpctl promote after synthetics #193411
Conversation
6aad601
to
47ebb1b
Compare
build: | ||
env: | ||
SERVICE_COMMIT_HASH: "$GIT_ABBREV_COMMIT" | ||
SERVICE: kibana | ||
REMOTE_SERVICE_CONFIG: https://raw.githubusercontent.com/elastic/serverless-gitops/main/gen/gpctl/kibana/dev.yaml | ||
DRY_RUN: "${DRY_RUN:-false}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer available? It was previously helpful for us to run this pipeline without promoting artifacts in support of testing pipeline changes on our side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionality was also not available in the previous pipeline.
Out of curiosity, have you tried to call this recently with DRY_RUN=true?
We do have a separate pipeline that only does the testing and no promotion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used this flag while testing the migrations to ensure we triggered the right downstream. I don't know if it's still in use, or would have future uses.
For more context, we added the Kibana triggers here: https://github.com/elastic/kibana/pull/178658/files
the corresponding escape hatch was added to promote.sh
here: https://github.com/elastic/gpctl/pull/261
It's true, that the gpctl-promote-with-e2e-tests
pipeline didn't have a reference to DRY_RUN
, but I believe, it did work for our case using the gpctl-promote
pipeline, as we directly triggered that (and thus the env section from the first linked PR was passed on). Through gpctl-promote-with-e2e-tests
this is probably lost, unless we pass along the env to the trigger step.
I don't think we're using the DRY_RUN
for any other use cases right now. So we can either add env passing there, or allow this to be removed for now. I'd go for the first option, since the hatch exists in promote.sh
, we may as well expose it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added support for a more explicit env variable called GPCTL_PROMOTE_DRY_RUN
in https://github.com/elastic/serverless-gitops/pull/4202.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Replacing pipeline gpctl-promote-with-e2e-tests with gpctl-promote-after-serverless-devenv-synthetics.
This will replace the execution of the E2E tests on promotion to dev/qa with the execution of the synthetics tests.