Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-7781 - switching bk pipeline to gpctl promote after synthetics #193411

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

mduarte
Copy link
Contributor

@mduarte mduarte commented Sep 19, 2024

Summary

Replacing pipeline gpctl-promote-with-e2e-tests with gpctl-promote-after-serverless-devenv-synthetics.
This will replace the execution of the E2E tests on promotion to dev/qa with the execution of the synthetics tests.

@mduarte mduarte requested a review from a team as a code owner September 19, 2024 11:35
@mduarte mduarte force-pushed the CP-7781/gpctl-promote-synthetics branch from 6aad601 to 47ebb1b Compare September 19, 2024 15:38
build:
env:
SERVICE_COMMIT_HASH: "$GIT_ABBREV_COMMIT"
SERVICE: kibana
REMOTE_SERVICE_CONFIG: https://raw.githubusercontent.com/elastic/serverless-gitops/main/gen/gpctl/kibana/dev.yaml
DRY_RUN: "${DRY_RUN:-false}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer available? It was previously helpful for us to run this pipeline without promoting artifacts in support of testing pipeline changes on our side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality was also not available in the previous pipeline.

Out of curiosity, have you tried to call this recently with DRY_RUN=true?
We do have a separate pipeline that only does the testing and no promotion.

Copy link
Member

@jbudz jbudz Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly not involved with the Kibana release pipeline, not sure how this was used.

@pheyos @delanni can you take a look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used this flag while testing the migrations to ensure we triggered the right downstream. I don't know if it's still in use, or would have future uses.

For more context, we added the Kibana triggers here: https://github.com/elastic/kibana/pull/178658/files

the corresponding escape hatch was added to promote.sh here: https://github.com/elastic/gpctl/pull/261

It's true, that the gpctl-promote-with-e2e-tests pipeline didn't have a reference to DRY_RUN, but I believe, it did work for our case using the gpctl-promote pipeline, as we directly triggered that (and thus the env section from the first linked PR was passed on). Through gpctl-promote-with-e2e-tests this is probably lost, unless we pass along the env to the trigger step.

I don't think we're using the DRY_RUN for any other use cases right now. So we can either add env passing there, or allow this to be removed for now. I'd go for the first option, since the hatch exists in promote.sh, we may as well expose it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added support for a more explicit env variable called GPCTL_PROMOTE_DRY_RUN in https://github.com/elastic/serverless-gitops/pull/4202.

@jbudz jbudz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 19, 2024
@mduarte mduarte enabled auto-merge (squash) September 25, 2024 13:39
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / machine learning - anomaly detection anomaly explorer with influencers with farequote based multi metric job Anomaly Charts as embeddable attaches an embeddable to a case

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mduarte mduarte merged commit 5e2a575 into elastic:main Sep 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants