Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Enable UI for Automated Actions in more rule types #193390

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Sep 19, 2024

A follow up PR to #191874.

This PR removes the feature flag that used to hide new functionality from the UI - due to intermediate release process.

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 labels Sep 19, 2024
@tomsonpl tomsonpl self-assigned this Sep 19, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl marked this pull request as ready for review September 20, 2024 07:02
@tomsonpl tomsonpl requested review from a team as code owners September 20, 2024 07:02
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomsonpl tomsonpl added the backport:skip This commit does not require backporting label Sep 20, 2024
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximpn maximpn removed the request for review from jpdjere September 24, 2024 13:50
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB -370.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.1KB 87.1KB -47.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM!

@tomsonpl tomsonpl merged commit 357a82c into elastic:main Sep 26, 2024
43 checks passed
@tomsonpl tomsonpl added backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting labels Sep 26, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 193390

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2024
…pes (#193390) (#194153)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[EDR Workflows] Enable UI for Automated Actions in more rule types
(#193390)](#193390)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T13:56:42Z","message":"[EDR
Workflows] Enable UI for Automated Actions in more rule types
(#193390)","sha":"357a82c8a7ea15366450ba4761837d0f78eadd3b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version"],"title":"[EDR Workflows] Enable
UI for Automated Actions in more rule
types","number":193390,"url":"https://github.com/elastic/kibana/pull/193390","mergeCommit":{"message":"[EDR
Workflows] Enable UI for Automated Actions in more rule types
(#193390)","sha":"357a82c8a7ea15366450ba4761837d0f78eadd3b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193390","number":193390,"mergeCommit":{"message":"[EDR
Workflows] Enable UI for Automated Actions in more rule types
(#193390)","sha":"357a82c8a7ea15366450ba4761837d0f78eadd3b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants