[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1 #193385
+96
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate Vuln Schema imports
|
/ci |
animehart
added
v8.16.0
backport:prev-minor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
animehart
added
the
release_note:skip
kqualters-elastic
approved these changes
Sep 19, 2024
maxcold
approved these changes
Sep 20, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // TODO: this needs to be defined in a versioned schema | |||
| import type { EcsEvent } from '@elastic/ecs'; | |||
| import { VulnSeverity } from '../types_old'; | |||
| import type { VulnSeverity } from '../..'; | |||
There was a problem hiding this comment.
I think it's better to import directly from ../../types/vulnerabilities than from index where it is re-exported
| @@ -151,7 +151,7 @@ export interface CnvmDashboardData { | |||
| topVulnerabilities: VulnerabilityStat[]; | |||
| } | |||
|
|
|||
| export type VulnSeverity = 'LOW' | 'MEDIUM' | 'HIGH' | 'CRITICAL' | 'UNKNOWN'; | |||
| // export type VulnSeverity = 'LOW' | 'MEDIUM' | 'HIGH' | 'CRITICAL' | 'UNKNOWN'; | |||
…/kibana into vulnerabilities-preview-phase1
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
elastic#193385) ## Summary In an attempt to make Reviewing easier and more accurate, the implementation of Vulnerabilities on Host.name flyout in Alerts Page will be split into 2 Phases Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package Phase 2: Implementing the feature (cherry picked from commit 434430a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…gin PHASE 1 (#193385) (#193640) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1 (#193385)](#193385) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T20:54:44Z","message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1 (#193385)\n\n## Summary\r\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature","sha":"434430a995487971137ce6b3182d2285758cd4c1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0"],"title":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1","number":193385,"url":"https://github.com/elastic/kibana/pull/193385","mergeCommit":{"message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1 (#193385)\n\n## Summary\r\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature","sha":"434430a995487971137ce6b3182d2285758cd4c1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193385","number":193385,"mergeCommit":{"message":"[Cloud Security] Vulnerabilities Preview & Refactor CSP Plugin PHASE 1 (#193385)\n\n## Summary\r\nIn an attempt to make Reviewing easier and more accurate, the\r\nimplementation of Vulnerabilities on Host.name flyout in Alerts Page\r\nwill be split into 2 Phases\r\n\r\nPhase 1: Move Functions, Utils or Helpers, Hooks, constants to Package\r\nPhase 2: Implementing the feature","sha":"434430a995487971137ce6b3182d2285758cd4c1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In an attempt to make Reviewing easier and more accurate, the implementation of Vulnerabilities on Host.name flyout in Alerts Page will be split into 2 Phases
Phase 1: Move Functions, Utils or Helpers, Hooks, constants to Package
Phase 2: Implementing the feature