[Fleet] Improve policy_secrets test suite performance #193359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6975[❌] x-pack/test/fleet_api_integration/config.epm.ts: 0/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6976[✅] x-pack/test/fleet_api_integration/config.epm.ts: 100/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6977[✅] x-pack/test/fleet_api_integration/config.epm.ts: 100/100 tests passed. |
nchaulet
changed the title
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6982[✅] x-pack/test/fleet_api_integration/config.fleet.ts: 100/100 tests passed. |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kpollich
approved these changes
Sep 19, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 8bd9085)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
…#193476) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Improve policy_secrets test suite performance (#193359)](#193359) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T19:39:46Z","message":"[Fleet] Improve policy_secrets test suite performance (#193359)","sha":"8bd90857ed667cbbcbe46041a4518366baa57883","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet] Improve policy_secrets test suite performance","number":193359,"url":"https://github.com/elastic/kibana/pull/193359","mergeCommit":{"message":"[Fleet] Improve policy_secrets test suite performance (#193359)","sha":"8bd90857ed667cbbcbe46041a4518366baa57883"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193359","number":193359,"mergeCommit":{"message":"[Fleet] Improve policy_secrets test suite performance (#193359)","sha":"8bd90857ed667cbbcbe46041a4518366baa57883"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #191924
While investigating the flakyness around those API integration test I found them pretty slow to run, that PR attempt to Improve test suite performance for policy_secrets, a lot of those tests where perfoming the same action again in a
beforeEachand checkin the result, that PR change that to improve the perofmanceThis was ran against the flaky test runner and seems to work as expected.
Before
After