Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Automatic Import] Modify codegen to autogenerate openAPI spec code (#193243) #193290

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…lastic#193243)

## Summary

elastic#186085 introduced OpenAPI spec
for Automatic Import APIs. Since there was a
[bug](elastic#186221) `x-codegen-enabled`
was set to `false`.

This PR modifies it to `true` and `node scripts/generate_openapi`
generated new API classes for the spec.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit e4180d2)
@bhapas bhapas added bug Fixes for quality problems that affect the customer experience Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Sep 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
integrationAssistant 46 49 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 947.8KB 947.9KB +17.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
integrationAssistant 3 4 +1
Unknown metric groups

API count

id before after diff
integrationAssistant 54 59 +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhapas

@kibanamachine kibanamachine merged commit 4993998 into elastic:8.x Sep 18, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Fixes for quality problems that affect the customer experience Feature:AutomaticImport release_note:fix Team:Security-Scalability Team label for Security Integrations Scalability Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants