[RCA] Events timeline !! #193265

shahzad31 · 2024-09-18T09:06:11Z

Summary

fixes https://github.com/elastic/observability-dev/issues/3925

Events timeline !!

obltmachine · 2024-09-18T09:06:27Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

afharo

kibana.jsonc changes LGTM

cauemarcondes

LGTM

…e-inv

benakansara

Code LGTM! Left some comments for adjustments as per the mockups

while testing the PR, I am not able to see annotation events even though I have annotations, any idea what could be the issue?

I was not able to move chart cursor in events timeline to sync with other visualizations on the page (worked other way around from viz to events timeline). Is there a known limitation we need to take into account?

I think we also need to introduce a global bucket size parameter for the investigation page, so all visualizations have same bucket size including events timeline (not in scope of this PR).

benakansara · 2024-10-01T13:52:41Z

...ution/investigate_app/public/pages/details/components/investigation_timeline/alert_event.tsx

+              width: 20,
+            }}
+          >
+            <EuiIcon type="warning" size="s" color="white" />


I think we wanted to keep "dot" icon with red color for alert and "dot" icon with black color for annotation events

.../investigate_app/public/pages/details/components/investigation_timeline/annotation_event.tsx

...ution/investigate_app/public/pages/details/components/investigation_timeline/alert_event.tsx

benakansara · 2024-10-01T16:59:32Z

while testing the PR, I am not able to see annotation events even though I have annotations, any idea what could be the issue?

it was due to wrong timerange. I verified the annotation events are correctly displayed.

x-pack/plugins/observability_solution/investigate_app/public/hooks/use_fetch_events.ts

...tigate_app/public/pages/details/components/investigation_timeline/investigation_timeline.tsx

…e-inv

benakansara

I have suggested few changes. Apart from that, I was not able to sync the cursor from events timeline (it works if I try to sync it from other visualizations on the page). Is it possible to improve this somehow?

Screen.Recording.2024-10-07.at.11.12.01.mov

...ity_solution/investigate_app/public/pages/details/components/events_timeline/alert_event.tsx

...solution/investigate_app/public/pages/details/components/events_timeline/events_timeline.tsx

…e-inv

benakansara

LGTM 🎉

kibana-ci · 2024-10-07T12:38:57Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 41ef949
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193265-41ef94936219

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`investigateApp`	572	578	+6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/investigation-shared`	81	82	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`investigateApp`	479.6KB	483.2KB	+3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`investigateApp`	6.4KB	6.6KB	+173.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/investigation-shared`	81	82	+1

History

💚 Build #238708 succeeded 26ea987
💛 Build #238299 was flaky 38bfa67
💔 Build #238059 failed 673cdd6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-10-07T13:41:44Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11216833881

kibanamachine · 2024-10-07T13:46:13Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - [Investigation app] add entities route and investigation Contextual Insight (#194432)

Manual backport

To create the backport manually run:

node scripts/backport --pr 193265

Questions ?

Please refer to the Backport tool documentation

shahzad31 · 2024-10-07T15:22:32Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Events timeline !! <img width="1728" alt="image" src="https://github.com/user-attachments/assets/c00c2368-5f7e-4e5e-a6a1-cbcfacb859cd"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 89f2802)

kibanamachine · 2024-10-08T13:48:55Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

# Backport This will backport the following commits from `main` to `8.x`: - [[RCA] Events timeline !! (#193265)](#193265)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

added events timeline

846d542

shahzad31 force-pushed the timeline-inv branch from 2816661 to 846d542 Compare September 30, 2024 13:47

shahzad31 marked this pull request as ready for review September 30, 2024 13:47

shahzad31 requested review from a team as code owners September 30, 2024 13:47

shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 30, 2024

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

673cdd6

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 30, 2024

afharo approved these changes Sep 30, 2024

View reviewed changes

cauemarcondes approved these changes Sep 30, 2024

View reviewed changes

shahzad31 added 2 commits October 1, 2024 10:44

Merge branch 'main' of https://github.com/elastic/kibana into timelin…

fe94ff3

…e-inv

types

38bfa67

benakansara reviewed Oct 1, 2024

View reviewed changes

...ution/investigate_app/public/pages/details/components/investigation_timeline/alert_event.tsx Outdated Show resolved Hide resolved

benakansara reviewed Oct 1, 2024

View reviewed changes

x-pack/plugins/observability_solution/investigate_app/public/hooks/use_fetch_events.ts Show resolved Hide resolved

...tigate_app/public/pages/details/components/investigation_timeline/investigation_timeline.tsx Outdated Show resolved Hide resolved

shahzad31 added 4 commits October 2, 2024 12:17

Merge branch 'main' of https://github.com/elastic/kibana into timelin…

c280897

…e-inv

fix refresh

c0d0496

PR feedback

52b99e6

type

26ea987

benakansara requested changes Oct 7, 2024

View reviewed changes

shahzad31 added 4 commits October 7, 2024 11:54

Merge branch 'main' of https://github.com/elastic/kibana into timelin…

60b5d7c

…e-inv

PR feedback

0cbe651

Merge branch 'main' of https://github.com/elastic/kibana into timelin…

b71cc36

…e-inv

add data points

41ef949

shahzad31 requested a review from benakansara October 7, 2024 11:41

benakansara approved these changes Oct 7, 2024

View reviewed changes

shahzad31 merged commit 89f2802 into elastic:main Oct 7, 2024
32 checks passed

shahzad31 deleted the timeline-inv branch October 7, 2024 13:41

kibanamachine added the v9.0.0 label Oct 7, 2024

shahzad31 mentioned this pull request Oct 7, 2024

[8.x] [RCA] Events timeline !! (#193265) #195280

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 8, 2024

kibanamachine added v8.16.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RCA] Events timeline !! #193265

[RCA] Events timeline !! #193265

shahzad31 commented Sep 18, 2024 •

edited

Loading

obltmachine commented Sep 18, 2024

afharo left a comment

cauemarcondes left a comment

benakansara left a comment •

edited

Loading

benakansara Oct 1, 2024

benakansara commented Oct 1, 2024 •

edited

Loading

benakansara left a comment

benakansara left a comment

kibana-ci commented Oct 7, 2024 •

edited

Loading

API count

kibanamachine commented Oct 7, 2024

kibanamachine commented Oct 7, 2024

shahzad31 commented Oct 7, 2024

kibanamachine commented Oct 8, 2024

[RCA] Events timeline !! #193265

[RCA] Events timeline !! #193265

Conversation

shahzad31 commented Sep 18, 2024 • edited Loading

Summary

obltmachine commented Sep 18, 2024

🤖 GitHub comments

afharo left a comment

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

benakansara left a comment • edited Loading

Choose a reason for hiding this comment

benakansara Oct 1, 2024

Choose a reason for hiding this comment

benakansara commented Oct 1, 2024 • edited Loading

benakansara left a comment

Choose a reason for hiding this comment

benakansara left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 7, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Oct 7, 2024

kibanamachine commented Oct 7, 2024

💔 All backports failed

Manual backport

Questions ?

shahzad31 commented Oct 7, 2024

💚 All backports created successfully

Questions ?

kibanamachine commented Oct 8, 2024

shahzad31 commented Sep 18, 2024 •

edited

Loading

benakansara left a comment •

edited

Loading

benakansara commented Oct 1, 2024 •

edited

Loading

kibana-ci commented Oct 7, 2024 •

edited

Loading