-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Update Elasticsearch specification metamodel #193239
Conversation
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for updating the types, @pquentin!
Not sure if type check will pass though, I vaguely remember manually replacing class
with interface
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary As mentioned in elastic#163335, the Elasticsearch specification metamodel is copied into Kibana, not imported. I don't know how to fix the original issue, so this pull request only updates the file, one year later. ### Checklist - [x] I checked that `node scripts/generate_console_definitions.js --source ../elasticsearch-specification/ --emptyDest` still works. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f6cff85)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#193405) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Update Elasticsearch specification metamodel (#193239)](#193239) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quentin Pradet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T10:31:13Z","message":"[Console] Update Elasticsearch specification metamodel (#193239)\n\n## Summary\r\n\r\nAs mentioned in #163335, the\r\nElasticsearch specification metamodel is copied into Kibana, not\r\nimported. I don't know how to fix the original issue, so this pull\r\nrequest only updates the file, one year later.\r\n\r\n### Checklist\r\n\r\n- [x] I checked that `node scripts/generate_console_definitions.js\r\n--source ../elasticsearch-specification/ --emptyDest` still works.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f6cff85c8d0ae4b32fbced558e831465d844e2ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console] Update Elasticsearch specification metamodel","number":193239,"url":"https://github.com/elastic/kibana/pull/193239","mergeCommit":{"message":"[Console] Update Elasticsearch specification metamodel (#193239)\n\n## Summary\r\n\r\nAs mentioned in #163335, the\r\nElasticsearch specification metamodel is copied into Kibana, not\r\nimported. I don't know how to fix the original issue, so this pull\r\nrequest only updates the file, one year later.\r\n\r\n### Checklist\r\n\r\n- [x] I checked that `node scripts/generate_console_definitions.js\r\n--source ../elasticsearch-specification/ --emptyDest` still works.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f6cff85c8d0ae4b32fbced558e831465d844e2ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193239","number":193239,"mergeCommit":{"message":"[Console] Update Elasticsearch specification metamodel (#193239)\n\n## Summary\r\n\r\nAs mentioned in #163335, the\r\nElasticsearch specification metamodel is copied into Kibana, not\r\nimported. I don't know how to fix the original issue, so this pull\r\nrequest only updates the file, one year later.\r\n\r\n### Checklist\r\n\r\n- [x] I checked that `node scripts/generate_console_definitions.js\r\n--source ../elasticsearch-specification/ --emptyDest` still works.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f6cff85c8d0ae4b32fbced558e831465d844e2ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quentin Pradet <[email protected]>
Summary
As mentioned in #163335, the Elasticsearch specification metamodel is copied into Kibana, not imported. I don't know how to fix the original issue, so this pull request only updates the file, one year later.
Checklist
node scripts/generate_console_definitions.js --source ../elasticsearch-specification/ --emptyDest
still works.For maintainers