[Fleet] Handle missing permissions when creating standalone agent API keys #193218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
commented
Sep 17, 2024
|
|
||
| export function sendCreateStandaloneAgentAPIKey(body: PostStandaloneAgentAPIKeyRequest['body']) { | ||
| return sendRequest<PostStandaloneAgentAPIKeyResponse>({ | ||
| return sendRequestForRq<PostStandaloneAgentAPIKeyResponse>({ |
There was a problem hiding this comment.
use sendRequestForRq as it throws on error, sendRequest return an error that was not handled
nchaulet
commented
Sep 17, 2024
| @@ -21,7 +21,7 @@ export const registerRoutes = (router: FleetAuthzRouter) => { | |||
| path: CREATE_STANDALONE_AGENT_API_KEY_ROUTE, | |||
| access: 'internal', | |||
| fleetAuthz: { | |||
| fleet: { all: true }, | |||
| fleet: { addAgents: true }, | |||
There was a problem hiding this comment.
we should only have the addAgents permission and not all
nchaulet
commented
Sep 17, 2024
| @@ -210,12 +210,15 @@ export function useGetCreateApiKey() { | |||
| const core = useStartServices(); | |||
|
|
|||
| const [apiKey, setApiKey] = useState<string | undefined>(undefined); | |||
| const [isLoading, setIsLoading] = useState(false); | |||
There was a problem hiding this comment.
I added a loading state, as it was weird to me to not have feedback while the API key is creating
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 18, 2024
… keys (elastic#193218) (cherry picked from commit 6a79e2d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 18, 2024
…nt API keys (#193218) (#193292) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Handle missing permissions when creating standalone agent API keys (#193218)](#193218) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-18T13:06:09Z","message":"[Fleet] Handle missing permissions when creating standalone agent API keys (#193218)","sha":"6a79e2d0be4d1cb9155b32afcff5753e1860b801","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet] Handle missing permissions when creating standalone agent API keys ","number":193218,"url":"https://github.com/elastic/kibana/pull/193218","mergeCommit":{"message":"[Fleet] Handle missing permissions when creating standalone agent API keys (#193218)","sha":"6a79e2d0be4d1cb9155b32afcff5753e1860b801"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193218","number":193218,"mergeCommit":{"message":"[Fleet] Handle missing permissions when creating standalone agent API keys (#193218)","sha":"6a79e2d0be4d1cb9155b32afcff5753e1860b801"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #189150
We were not handling errors when creating standalone agent API keys in the Fleet UI.
That PR address that by:
UI Changes