[Authz] Eslint Rule for Security Config #193187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elena-shostak
force-pushed
the
191715-eslint-security-config
branch
from
17f511c to
f1983c8
Compare
elena-shostak
force-pushed
the
191715-eslint-security-config
branch
from
f1983c8 to
b1d9bd6
Compare
elena-shostak
added
Team:Security
elena-shostak
changed the title
elena-shostak
added
Feature:Security/Authorization
|
@elasticmachine merge upstream |
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
Pinging @elastic/kibana-security (Team:Security) |
|
@elasticmachine merge upstream |
jbudz
reviewed
Sep 23, 2024
jbudz
approved these changes
Sep 24, 2024
elena-shostak
commented
Sep 25, 2024
packages/kbn-eslint-plugin-eslint/rules/no_deprecated_authz_config.test.js
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ESLint rule is introduced to enforce the migration of access tags in route configurations to the
security.authz.requiredPrivilegesfield. It ensures that security configurations are correctly applied in both standard and versioned routes. Will be enabled after #191973 is merged.The rule covers:
Access Tag Migration. Moves
access:<privilege>tags from theoptions.tagsproperty tosecurity.authz.requiredPrivileges. Preserves any non-access tags in the tags property.Missing Security Config Detection. Reports an error if no security config is found in the route or version.
Suggests adding a default security configuration
authz: { enabled: false }.Note
There is an indentation issues with the test,
dedentdoesn't solve most of the issues and sinceRuleTesterwas designed to test a single rule at a time,I couldn't enable multiple fixes (including indent ones) before checking output.Manually adjusted the indentation.
Checklist
Fixes: #191715
Related: #191710