Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [APM] Empty/null service.environment error fix (#192448) #193137

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

fixes [192380](elastic#192380)

## Summary

Revert the `service.environment` comparison change. Using `equals` can
be dangerous if the field is null, resulting in errors. The previous
version worked fine, so I decided to revert the change that modified the
condition.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 4a2dd8a)
@kibanamachine kibanamachine enabled auto-merge (squash) September 17, 2024 10:41
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @crespocarlos

@kibanamachine kibanamachine merged commit 62da3b6 into elastic:8.15 Sep 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants