Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] 3P Misconfiguration and vulnerabilities page empty state #193051

Merged
merged 20 commits into from
Sep 25, 2024
Merged

[Cloud Security] 3P Misconfiguration and vulnerabilities page empty state #193051

merged 20 commits into from
Sep 25, 2024

Conversation

JordanSh
Copy link
Contributor

@JordanSh JordanSh commented Sep 16, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #187229
Resolves #190505

Screen.Recording.2024-09-16.at.19.12.15.mov
  • Changed the previous UI for the native empty state prompt
  • Adjusted previous tests to new texts or IDs
  • Added SVGs for clouds and vendors
  • Adjusted Vendor SVG to be easy to recolor when needed
  • Added Wiz link to the 3P prompt
  • Added unit tests + FTRs

@JordanSh JordanSh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Sep 16, 2024
@JordanSh JordanSh self-assigned this Sep 16, 2024
@JordanSh JordanSh requested a review from maxcold September 17, 2024 15:32
@JordanSh JordanSh marked this pull request as ready for review September 17, 2024 15:32
@JordanSh JordanSh requested a review from a team as a code owner September 17, 2024 15:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@maxcold
Copy link
Contributor

maxcold commented Sep 19, 2024

@JordanSh If we are not releasing 3rd party features in the dashboard and benchmarks, are we ok with promoting 3rd party integrations on these pages empty states? might be confusing for users - you go and install wiz from the dashboard page but you don't see any wiz data there after

maxcold
maxcold approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product question, do we plan Learn more link there to point to the docs? I think it's needed in the empty state to explain users that for Misconfigurations to show up they need specific version of the integration with cloud_configuration_finding data stream enabled. It is possible that they already have this integration but of the older version or with only a specific data stream enabled say audit which has nothing to do with our Findings. So seeing this empty state might be confusing for them if we only have link to "add integration"

...k/plugins/cloud_security_posture/public/components/no_findings_states/no_findings_states.tsx Outdated
<EuiFlexGroup>
<EuiFlexItem>
<EuiEmptyPrompt
style={{ padding: 24 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any eui const to use here instead of hardcoding number?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 647 651 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 496.5KB 505.3KB +8.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 17.8KB 17.8KB +41.0B
Unknown metric groups

miscellaneous assets size

id before after diff
cloudSecurityPosture 974.9KB 2.7MB ⚠️ +1.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @JordanSh

@JordanSh JordanSh added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Sep 25, 2024
@JordanSh
Copy link
Contributor Author

@JordanSh If we are not releasing 3rd party features in the dashboard and benchmarks, are we ok with promoting 3rd party integrations on these pages empty states? might be confusing for users - you go and install wiz from the dashboard page but you don't see any wiz data there after

Dashboard has different mechanism since each integration has its own page. But i did remove this part from the rules page

@JordanSh JordanSh merged commit 0212c69 into elastic:main Sep 25, 2024
22 checks passed
@JordanSh JordanSh changed the title [Cloud Security] 3P Misconfiguration page empty state [Cloud Security] 3P Misconfiguration and vulnerabilities page empty state Sep 25, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
@JordanSh
[Cloud Security] 3P Misconfiguration page empty state (elastic#193051)
18cdb4a 
(cherry picked from commit 0212c69)
@kibanamachine kibanamachine mentioned this pull request Sep 25, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 25, 2024
@kibanamachine @JordanSh
[8.x] [Cloud Security] 3P Misconfiguration page empty state (#193051) (…
3d649a8 
…#194034)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] 3P Misconfiguration page empty state
(#193051)](#193051)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T15:35:24Z","message":"[Cloud
Security] 3P Misconfiguration page empty state
(#193051)","sha":"0212c69e0ef5272bd93aa83e667dd57fadac1764","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor"],"title":"[Cloud Security] 3P
Misconfiguration page empty
state","number":193051,"url":"https://github.com/elastic/kibana/pull/193051","mergeCommit":{"message":"[Cloud
Security] 3P Misconfiguration page empty state
(#193051)","sha":"0212c69e0ef5272bd93aa83e667dd57fadac1764"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193051","number":193051,"mergeCommit":{"message":"[Cloud
Security] 3P Misconfiguration page empty state
(#193051)","sha":"0212c69e0ef5272bd93aa83e667dd57fadac1764"}}]}]
BACKPORT-->

Co-authored-by: Jordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

Assignees

@JordanSh JordanSh

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerabilities 3P Empty states Misconfigurations 3P Empty states
5 participants
@JordanSh @elasticmachine @maxcold @kibana-ci @kibanamachine