[Security Solution] Add a missing domain tag to Endpoint Exceptions API #193019
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
vitaliidm
approved these changes
Sep 17, 2024
Comment on lines
28
to
+34
| description: 'Endpoint Exceptions API allow you to manage Endpoint lists.', | ||
| }, | ||
| tags: [ | ||
| { | ||
| name: 'Security Solution Endpoint Exceptions API', | ||
| description: | ||
| "Endpoint Exceptions API allows you to manage detection rule endpoint exceptions to prevent a rule from generating an alert from incoming events even when the rule's other criteria are met.", |
There was a problem hiding this comment.
nit: should value of description be the same in both cases, similarly to https://github.com/elastic/kibana/pull/189621/files#diff-1fbdf4b15cda189b67f964f0f03e3c46bf2bbc85f538334b4c9ed38db86aca43R52-R61 ?
There was a problem hiding this comment.
Exceptions and Endpoint Exceptions APIs are different domains or rather sub-domains. Despite Endpoint Exceptions API reuses Exceptions API schemas under the hood it represents a different set of interactions with the product. UI displays endpoint exceptions in a different tab.
We didn't have Endpoint Exceptions API documented earlier. IMHO having the same tag's name and description might confuse users. Though I'm curious if there are any concerns with that.
There was a problem hiding this comment.
No, that's not what I meant.
Description on 28th line is different to description on 34.
Whether in PR I referred, both description are the same in tags and root of object
maximpn
force-pushed
the
add-missing-tag-to-endpoint-exceptions
branch
from
ca74100 to
3f04b14
Compare
maximpn
added
backport
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @maximpn |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Sep 25, 2024
…PI (elastic#193019) **Addresses:** elastic#183375 ## Summary This PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in elastic#189621. (cherry picked from commit 09374ad) # Conflicts: # packages/kbn-securitysolution-endpoint-exceptions-common/docs/openapi/ess/security_solution_endpoint_exceptions_api_2023_10_31.bundled.schema.yaml # packages/kbn-securitysolution-endpoint-exceptions-common/docs/openapi/serverless/security_solution_endpoint_exceptions_api_2023_10_31.bundled.schema.yaml
maximpn
added a commit
that referenced
this pull request
Sep 25, 2024
…ions API (#193019) (#193984) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Add a missing domain tag to Endpoint Exceptions API (#193019)](#193019) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T11:23:11Z","message":"[Security Solution] Add a missing domain tag to Endpoint Exceptions API (#193019)\n\n**Addresses:** https://github.com/elastic/kibana/issues/183375\r\n\r\n## Summary\r\n\r\nThis PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in https://github.com/elastic/kibana/pull/189621.","sha":"09374ad2ce5ba96b61a1d300264d2465f34e2326","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","docs","Team:Detections and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.16.0"],"number":193019,"url":"https://github.com/elastic/kibana/pull/193019","mergeCommit":{"message":"[Security Solution] Add a missing domain tag to Endpoint Exceptions API (#193019)\n\n**Addresses:** https://github.com/elastic/kibana/issues/183375\r\n\r\n## Summary\r\n\r\nThis PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in https://github.com/elastic/kibana/pull/189621.","sha":"09374ad2ce5ba96b61a1d300264d2465f34e2326"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193019","number":193019,"mergeCommit":{"message":"[Security Solution] Add a missing domain tag to Endpoint Exceptions API (#193019)\n\n**Addresses:** https://github.com/elastic/kibana/issues/183375\r\n\r\n## Summary\r\n\r\nThis PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in https://github.com/elastic/kibana/pull/189621.","sha":"09374ad2ce5ba96b61a1d300264d2465f34e2326"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Nov 12, 2024
…PI (elastic#193019) **Addresses:** elastic#183375 This PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in elastic#189621. (cherry picked from commit 09374ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #183375
Summary
This PR adds a missing domain tag to Endpoint Exceptions API. The rest API endpoints got their tags in #189621.