Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [APM[Services] Add custom events to new ServiceTabEmptyState (#192385) #193005

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[8.x] [APM[Services] Add custom events to new ServiceTabEmptyState (#192385) #193005

merged 1 commit into from
Sep 16, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@iblancof
[APM[Services] Add custom events to new ServiceTabEmptyState (elastic…
03b33ee 
…#192385)

## Summary

Closes elastic#190770.

With the new empty state added for certain tabs when a service only has
log signals, we're introducing telemetry to track its usage and impact.
The events being implemented have been defined
[here](elastic/observability-dev#3462 (comment))
and agreed upon with product.

|Button/Link|Sent event|
|-|-|
|Add APM|![Screenshot 2024-09-09 at 17 33
50](https://github.com/user-attachments/assets/a0331727-1b32-41bf-85fe-322d5b519f8b)|
|Try it|![Screenshot 2024-09-09 at 17 34
10](https://github.com/user-attachments/assets/c92633b1-adfc-4787-a147-44c76f50a07b)|
|Learn more|![Screenshot 2024-09-09 at 17 34
22](https://github.com/user-attachments/assets/9a8eae57-f810-4414-968e-6968c65029d6)|

---------

Co-authored-by: Katerina <[email protected]>
Co-authored-by: Caue Marcondes <[email protected]>
(cherry picked from commit 61fcb0f)
@kibanamachine kibanamachine enabled auto-merge (squash) September 16, 2024 12:39
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 16, 2024
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / FilterPopover renders button label correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +261.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 39.9KB 40.4KB +560.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 12 13 +1

Total ESLint disabled count

id before after diff
apm 82 83 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @iblancof

@kibanamachine kibanamachine merged commit b3b25dc into elastic:8.x Sep 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@iblancof iblancof

Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @iblancof