[Inventory] Project restructure to show entities grid #192991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cauemarcondes
added
release_note:skip
crespocarlos
approved these changes
Sep 16, 2024
botelastic
bot
added
the
ci:project-deploy-observability
cauemarcondes
changed the title
iblancof
approved these changes
Sep 16, 2024
| export const listEntityTypesRoute = createInventoryServerRoute({ | ||
| endpoint: 'GET /internal/inventory/entity_types', | ||
| export const listLatestEntitiesRoute = createInventoryServerRoute({ | ||
| endpoint: 'GET /internal/inventory/entities', |
There was a problem hiding this comment.
Should we try to get rid off the /internal/ path on new stuff?
There was a problem hiding this comment.
According to the API guidelines, if this is intended to be an internal API, we should keep it.
There was a problem hiding this comment.
Oh, sorry! I got confused by this documentation about doing some changes in internal API access and may have misunderstood something.
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Show resolved
Hide resolved
kpatticha
approved these changes
Sep 16, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 17, 2024
Inventory plugin restructure. Creating server API to fetch entities and initial data grid load on the page. (cherry picked from commit 15c752c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 17, 2024
…#193139) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Project restructure to show entities grid (#192991)](#192991) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T10:38:01Z","message":"[Inventory] Project restructure to show entities grid (#192991)\n\nInventory plugin restructure. Creating server API to fetch entities and\r\ninitial data grid load on the page.","sha":"15c752cdc86c1ca5f7d0c30b3305e477cb14e669","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory] Project restructure to show entities grid","number":192991,"url":"https://github.com/elastic/kibana/pull/192991","mergeCommit":{"message":"[Inventory] Project restructure to show entities grid (#192991)\n\nInventory plugin restructure. Creating server API to fetch entities and\r\ninitial data grid load on the page.","sha":"15c752cdc86c1ca5f7d0c30b3305e477cb14e669"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192991","number":192991,"mergeCommit":{"message":"[Inventory] Project restructure to show entities grid (#192991)\n\nInventory plugin restructure. Creating server API to fetch entities and\r\ninitial data grid load on the page.","sha":"15c752cdc86c1ca5f7d0c30b3305e477cb14e669"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory plugin restructure. Creating server API to fetch entities and initial data grid load on the page.