[DOCS] Remove "Save changes" statement from the query page of the Playground #192945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-docs (Team:Docs) |
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
leemthompo
added
the
release_note:skip
leemthompo
approved these changes
Sep 15, 2024
leemthompo
added
v8.16.0
backport:version
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
…yground (elastic#192945) ## Summary On the ["View and modify queries" page](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html) under the Playground documentation, there is a statement "Click Save changes." But there is no such button on Kibana 8.15.1 and changes are applied automatically, so this statement is not needed. I can see "Save changes" button on 8.14.0, so I believe it disappears from 8.15.0. <img width="1440" alt="image" src="https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755"> (cherry picked from commit 463a636)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
…yground (elastic#192945) ## Summary On the ["View and modify queries" page](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html) under the Playground documentation, there is a statement "Click Save changes." But there is no such button on Kibana 8.15.1 and changes are applied automatically, so this statement is not needed. I can see "Save changes" button on 8.14.0, so I believe it disappears from 8.15.0. <img width="1440" alt="image" src="https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755"> (cherry picked from commit 463a636)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
… page of the Playground (#192945) (#193586) # Backport This will backport the following commits from `main` to `8.x`: - [[DOCS] Remove "Save changes" statement from the query page of the Playground (#192945)](#192945) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dai Sugimori","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T13:45:29Z","message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","v8.15.0","v8.16.0","backport:version"],"title":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground","number":192945,"url":"https://github.com/elastic/kibana/pull/192945","mergeCommit":{"message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192945","number":192945,"mergeCommit":{"message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dai Sugimori <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…y page of the Playground (#192945) (#193584) # Backport This will backport the following commits from `main` to `8.15`: - [[DOCS] Remove "Save changes" statement from the query page of the Playground (#192945)](#192945) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dai Sugimori","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T13:45:29Z","message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","v8.15.0","v8.16.0","backport:version"],"title":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground","number":192945,"url":"https://github.com/elastic/kibana/pull/192945","mergeCommit":{"message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192945","number":192945,"mergeCommit":{"message":"[DOCS] Remove \"Save changes\" statement from the query page of the Playground (#192945)\n\n## Summary\r\n\r\nOn the [\"View and modify queries\"\r\npage](https://www.elastic.co/guide/en/kibana/8.15/playground-query.html)\r\nunder the Playground documentation, there is a statement \"Click Save\r\nchanges.\" But there is no such button on Kibana 8.15.1 and changes are\r\napplied automatically, so this statement is not needed.\r\n\r\nI can see \"Save changes\" button on 8.14.0, so I believe it disappears\r\nfrom 8.15.0.\r\n\r\n<img width=\"1440\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/009d72fa-3adf-4c9b-8e49-f068df638755\">","sha":"463a63603fb05997ec2e44d50d83a7b852db02b2"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dai Sugimori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the "View and modify queries" page under the Playground documentation, there is a statement "Click Save changes." But there is no such button on Kibana 8.15.1 and changes are applied automatically, so this statement is not needed.
I can see "Save changes" button on 8.14.0, so I believe it disappears from 8.15.0.