[Detection Engine] Skip flakes in MKI env #192936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
release_note:skip
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @yctercero |
dhurley14
approved these changes
Sep 16, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 17, 2024
## Summary After discussion with team leads - skipping flakey tests in MKI environment to be reassessed. If any of these can be moved to FTR, we should do so or see if there are ways we can rewrite the tests to stabilize. (cherry picked from commit ab4d039)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Detection Engine] Skip flakes in MKI env (#192936)](#192936) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T15:56:56Z","message":"[Detection Engine] Skip flakes in MKI env (#192936)\n\n## Summary\r\n\r\nAfter discussion with team leads - skipping flakey tests in MKI\r\nenvironment to be reassessed. If any of these can be moved to FTR, we\r\nshould do so or see if there are ways we can rewrite the tests to\r\nstabilize.","sha":"ab4d039fcf787d9194a0c6276830facce53cf189","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detection Engine","v8.16.0"],"title":"[Detection Engine] Skip flakes in MKI env","number":192936,"url":"https://github.com/elastic/kibana/pull/192936","mergeCommit":{"message":"[Detection Engine] Skip flakes in MKI env (#192936)\n\n## Summary\r\n\r\nAfter discussion with team leads - skipping flakey tests in MKI\r\nenvironment to be reassessed. If any of these can be moved to FTR, we\r\nshould do so or see if there are ways we can rewrite the tests to\r\nstabilize.","sha":"ab4d039fcf787d9194a0c6276830facce53cf189"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192936","number":192936,"mergeCommit":{"message":"[Detection Engine] Skip flakes in MKI env (#192936)\n\n## Summary\r\n\r\nAfter discussion with team leads - skipping flakey tests in MKI\r\nenvironment to be reassessed. If any of these can be moved to FTR, we\r\nshould do so or see if there are ways we can rewrite the tests to\r\nstabilize.","sha":"ab4d039fcf787d9194a0c6276830facce53cf189"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After discussion with team leads - skipping flakey tests in MKI environment to be reassessed. If any of these can be moved to FTR, we should do so or see if there are ways we can rewrite the tests to stabilize.