[8.x] [ML] Functional tests - stabilize model list tests (#192851) #192869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR stabilizes the model list tests by adding a wait for global loading before checking the collapsed action button. ### Details I was able to reproduce the original failure by running the test suite in my local browser with network speed throttled to 3G: after stopping a model deployment, the row actions change and during that time the global loading is active. Checking the collapsed action button too early (i.e. before global loading finished) returns a false positive and then the next step will try to click that button which in the mean time disappeared. Adding the wait for global loading before checking the collapsed actions button fixed for my local runs with throttling. Closes elastic#175443 (cherry picked from commit c1b7d82)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @pheyos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation