Fix bug in overdue task metric script #192863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
Sep 13, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: cc @mikecote |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2024
Fixing a bug from elastic#192603 where tasks in idle wouldn't show up in overdue metrics. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['actions:*']` in your kibana.yml 2. Startup Elasticsearch and Kibana 3. Create an always firing rule that logs a server log message 4. Observe the metrics endpoint `/api/task_manager/metrics` and that the overdue metrics overall, for actions and for server log increase over time because the task is skipped (cherry picked from commit 1854acd)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix bug in overdue task metric script (#192863)](#192863) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-13T15:51:47Z","message":"Fix bug in overdue task metric script (#192863)\n\nFixing a bug from #192603 where\r\ntasks in idle wouldn't show up in overdue metrics.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types: ['actions:*']` in\r\nyour kibana.yml\r\n2. Startup Elasticsearch and Kibana\r\n3. Create an always firing rule that logs a server log message\r\n4. Observe the metrics endpoint `/api/task_manager/metrics` and that the\r\noverdue metrics overall, for actions and for server log increase over\r\ntime because the task is skipped","sha":"1854acd557531501ed600204ac766c5670c29f38","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Fix bug in overdue task metric script","number":192863,"url":"https://github.com/elastic/kibana/pull/192863","mergeCommit":{"message":"Fix bug in overdue task metric script (#192863)\n\nFixing a bug from #192603 where\r\ntasks in idle wouldn't show up in overdue metrics.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types: ['actions:*']` in\r\nyour kibana.yml\r\n2. Startup Elasticsearch and Kibana\r\n3. Create an always firing rule that logs a server log message\r\n4. Observe the metrics endpoint `/api/task_manager/metrics` and that the\r\noverdue metrics overall, for actions and for server log increase over\r\ntime because the task is skipped","sha":"1854acd557531501ed600204ac766c5670c29f38"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192863","number":192863,"mergeCommit":{"message":"Fix bug in overdue task metric script (#192863)\n\nFixing a bug from #192603 where\r\ntasks in idle wouldn't show up in overdue metrics.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types: ['actions:*']` in\r\nyour kibana.yml\r\n2. Startup Elasticsearch and Kibana\r\n3. Create an always firing rule that logs a server log message\r\n4. Observe the metrics endpoint `/api/task_manager/metrics` and that the\r\noverdue metrics overall, for actions and for server log increase over\r\ntime because the task is skipped","sha":"1854acd557531501ed600204ac766c5670c29f38"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mike Côté <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug from #192603 where tasks in idle wouldn't show up in overdue metrics.
To verify
xpack.task_manager.unsafe.exclude_task_types: ['actions:*']in your kibana.yml/api/task_manager/metricsand that the overdue metrics overall, for actions and for server log increase over time because the task is skipped