Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] skip tests that fail on chrome 128+ #192830

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Sep 13, 2024

Summary

Currently google-chrome-stable is pinned to v127.x.x as with v128.x.x we get a few FTR breakages (some of them on visual inaccuracies, some other).

We'd like to unpin chrome, and move on to 128, and start fixing these test failures. So we're skipping the failures temporarily, bumping chrome to 128, then allow for unskipping and fixing these.

Relates to: https://github.com/elastic/kibana-operations/issues/199

@delanni delanni changed the title skip tests that fail on chrome 128+ [ci] skip tests that fail on chrome 128+ Sep 13, 2024
@delanni delanni force-pushed the skip-tests-failing-on-chrome-next branch from 6e2fdb8 to d345565 Compare September 13, 2024 14:53
@delanni delanni marked this pull request as ready for review September 13, 2024 16:47
@delanni delanni requested review from a team as code owners September 13, 2024 16:47
@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Sep 13, 2024
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM

created #192910 to track skipped presentation team tests

@delanni
Copy link
Contributor Author

delanni commented Sep 16, 2024

@elastic/kibana-visualizations - could you also give an approval and a keepsake item your backlog to adjust these after we roll out the current chrome?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit f458714 into elastic:main Sep 16, 2024
22 checks passed
@delanni delanni deleted the skip-tests-failing-on-chrome-next branch September 16, 2024 13:18
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2024
## Summary
Currently `google-chrome-stable` is pinned to `v127.x.x` as with
`v128.x.x` we get a few FTR breakages (some of them on visual
inaccuracies, some other).

We'd like to unpin chrome, and move on to 128, and start fixing these
test failures. So we're skipping the failures temporarily, bumping
chrome to 128, then allow for unskipping and fixing these.

(cherry picked from commit f458714)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 192830

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 16, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ci] skip tests that fail on chrome 128+
(#192830)](#192830)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T13:18:49Z","message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing
these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"[ci]
skip tests that fail on chrome
128+","number":192830,"url":"https://github.com/elastic/kibana/pull/192830","mergeCommit":{"message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing
these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192830","number":192830,"mergeCommit":{"message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
@delanni
Copy link
Contributor Author

delanni commented Sep 20, 2024

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

delanni added a commit to delanni/kibana that referenced this pull request Sep 20, 2024
## Summary
Currently `google-chrome-stable` is pinned to `v127.x.x` as with
`v128.x.x` we get a few FTR breakages (some of them on visual
inaccuracies, some other).

We'd like to unpin chrome, and move on to 128, and start fixing these
test failures. So we're skipping the failures temporarily, bumping
chrome to 128, then allow for unskipping and fixing these.

(cherry picked from commit f458714)

# Conflicts:
#	test/functional/apps/kibana_overview/_analytics.ts
#	x-pack/test/functional/apps/lens/group6/workspace_size.ts
delanni added a commit that referenced this pull request Sep 20, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[ci] skip tests that fail on chrome 128+
(#192830)](#192830)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T13:18:49Z","message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing
these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","v8.16.0"],"number":192830,"url":"https://github.com/elastic/kibana/pull/192830","mergeCommit":{"message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing
these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192830","number":192830,"mergeCommit":{"message":"[ci]
skip tests that fail on chrome 128+ (#192830)\n\n## Summary\r\nCurrently
`google-chrome-stable` is pinned to `v127.x.x` as with\r\n`v128.x.x` we
get a few FTR breakages (some of them on visual\r\ninaccuracies, some
other).\r\n\r\nWe'd like to unpin chrome, and move on to 128, and start
fixing these\r\ntest failures. So we're skipping the failures
temporarily, bumping\r\nchrome to 128, then allow for unskipping and
fixing
these.","sha":"f4587149987aa21ec9345e887bc7121d75792ea5"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/193012","number":193012,"state":"MERGED","mergeCommit":{"sha":"612e5780f66598d54d6af5dc7b4b21c294beea39","message":"[8.x]
[ci] skip tests that fail on chrome 128+ (#192830) (#193012)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [[ci] skip tests that fail on chrome
128+\n(#192830)](https://github.com/elastic/kibana/pull/192830)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Alex\nSzabo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-09-16T13:18:49Z\",\"message\":\"[ci]\nskip
tests that fail on chrome 128+ (#192830)\\n\\n##
Summary\\r\\nCurrently\n`google-chrome-stable` is pinned to `v127.x.x`
as with\\r\\n`v128.x.x` we\nget a few FTR breakages (some of them on
visual\\r\\ninaccuracies, some\nother).\\r\\n\\r\\nWe'd like to unpin
chrome, and move on to 128, and start\nfixing these\\r\\ntest failures.
So we're skipping the failures\ntemporarily, bumping\\r\\nchrome to 128,
then allow for unskipping
and\nfixing\nthese.\",\"sha\":\"f4587149987aa21ec9345e887bc7121d75792ea5\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:all-open\"],\"title\":\"[ci]\nskip
tests that fail on
chrome\n128+\",\"number\":192830,\"url\":\"https://github.com/elastic/kibana/pull/192830\",\"mergeCommit\":{\"message\":\"[ci]\nskip
tests that fail on chrome 128+ (#192830)\\n\\n##
Summary\\r\\nCurrently\n`google-chrome-stable` is pinned to `v127.x.x`
as with\\r\\n`v128.x.x` we\nget a few FTR breakages (some of them on
visual\\r\\ninaccuracies, some\nother).\\r\\n\\r\\nWe'd like to unpin
chrome, and move on to 128, and start\nfixing these\\r\\ntest failures.
So we're skipping the failures\ntemporarily, bumping\\r\\nchrome to 128,
then allow for unskipping
and\nfixing\nthese.\",\"sha\":\"f4587149987aa21ec9345e887bc7121d75792ea5\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/192830\",\"number\":192830,\"mergeCommit\":{\"message\":\"[ci]\nskip
tests that fail on chrome 128+ (#192830)\\n\\n##
Summary\\r\\nCurrently\n`google-chrome-stable` is pinned to `v127.x.x`
as with\\r\\n`v128.x.x` we\nget a few FTR breakages (some of them on
visual\\r\\ninaccuracies, some\nother).\\r\\n\\r\\nWe'd like to unpin
chrome, and move on to 128, and start\nfixing these\\r\\ntest failures.
So we're skipping the failures\ntemporarily, bumping\\r\\nchrome to 128,
then allow for unskipping and\nfixing
these.\",\"sha\":\"f4587149987aa21ec9345e887bc7121d75792ea5\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Alex Szabo <[email protected]>"}}]}] BACKPORT-->
@delanni
Copy link
Contributor Author

delanni commented Sep 20, 2024

@nreese + @dej611 - chrome has been unpinned, FTRs on all branches are now running chrome 129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.15.2 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants