[8.15] [Synthetics] Update parsing to skip replacing missing values (#192662) #192752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#192662) ## Summary Based on user reported issue in https://discuss.elastic.co/t/elastic-lightweight-monitor-host-name-no-longer-using-current-host-name/366421 Update parsing to skip replacing missing values !! ### Before https://${host.name} would be replaced with "https://", ### After Var value remain as is so that it would look for env variable "https://${host.name}", ### Testing can be tested in the ui , go to add monitor ui , user params in url field and use inspect configuration to see parsed value, enabled inspect button from kibana advanced settings observability inspect ES queries !! <img width="852" alt="image" src="https://github.com/user-attachments/assets/66bf460a-7d63-4fb3-993d-1caaa6812583"> <img width="1106" alt="image" src="https://github.com/user-attachments/assets/6f5e97c6-182a-4cd1-a345-976c321d449a"> --------- Co-authored-by: Justin Kambic <[email protected]> (cherry picked from commit e94024b)
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @shahzad31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation