-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add ES-request time telemetry to Lens embeddable #192743
Merged
thomasneirynck
merged 16 commits into
elastic:main
from
thomasneirynck:lens/add_es_request_telemetry
Sep 20, 2024
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4341815
Add telemetry to Lens embeddable
thomasneirynck 823d4d7
use enum
thomasneirynck d8ccadd
fix import order
thomasneirynck 8f77339
fix type check
thomasneirynck 5291df0
fix import
thomasneirynck 64c6fde
Merge branch 'main' into lens/add_es_request_telemetry
thomasneirynck 5ce81f2
Merge branch 'main' of github.com:elastic/kibana into lens/add_es_req…
thomasneirynck 0138c75
remove duplication
thomasneirynck ca8d25b
do not change meaning of existing time_to_data metric
thomasneirynck c8ce764
Merge branch 'lens/add_es_request_telemetry' of github.com:thomasneir…
thomasneirynck b2ab31e
fix bug
thomasneirynck 6e9d638
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine c9da1cd
linting issues
thomasneirynck d934e58
Merge branch 'lens/add_es_request_telemetry' of github.com:thomasneir…
thomasneirynck c89058a
Update x-pack/plugins/lens/public/report_performance_metric_util.ts
thomasneirynck afd3b7e
Merge branch 'main' into lens/add_es_request_telemetry
thomasneirynck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
x-pack/plugins/lens/public/report_performance_metric_util.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { RequestStatus } from '@kbn/inspector-plugin/common'; | ||
import type { Adapters } from '@kbn/inspector-plugin/public'; | ||
import { estypes } from '@elastic/elasticsearch'; | ||
|
||
export interface ILensRequestPerformance { | ||
requestTimeTotal: number; | ||
esTookTotal: number; | ||
} | ||
|
||
export function getSuccessfulRequestTimings( | ||
inspectorAdapters: Adapters | ||
): ILensRequestPerformance | null { | ||
const requests = inspectorAdapters.requests?.getRequests() || []; | ||
|
||
let totalTookTime = 0; | ||
let totalTime = 0; | ||
for (let i = 0; i < requests.length; i++) { | ||
const request = requests[i]; | ||
if (request.status !== RequestStatus.OK) { | ||
return null; | ||
} | ||
totalTookTime += | ||
(request.response?.json as { rawResponse: estypes.SearchResponse | undefined } | undefined) | ||
?.rawResponse?.took ?? 0; | ||
totalTime += request.time || 0; | ||
} | ||
|
||
return { | ||
requestTimeTotal: totalTime, | ||
esTookTotal: totalTookTime, | ||
}; | ||
thomasneirynck marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#192245 changed the meaning of this
time_to_data
. I wouldn't change it, since it changes how to interpret that metric in historical comparisons. If we really need the difference, we can compute it at runtime (runtime fields, esql, ...)