Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add border to text editor for ES|QL data visualizer #192726

Merged
merged 8 commits into from
Sep 20, 2024
Merged

[ML] Add border to text editor for ES|QL data visualizer #192726

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b1c6b7
Add border
qn895 Sep 12, 2024
a8a54dc
Merge remote-tracking branch 'upstream/main' into ml-esql-dv-add-border
qn895 Sep 16, 2024
22727da
Fix overlay
qn895 Sep 16, 2024
08b3c83
Update to using scroll
qn895 Sep 18, 2024
7f308c2
Merge branch 'main' into ml-esql-dv-add-border
elasticmachine Sep 19, 2024
fc3c463
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine Sep 19, 2024
eda29f0
Merge remote-tracking branch 'upstream/main' into ml-esql-dv-add-border
qn895 Sep 20, 2024
e869e89
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions ...ndex_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_esql.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,24 @@ export const IndexDataVisualizerESQL: FC<IndexDataVisualizerESQLProps> = (dataVi
</EuiFlexGroup>
</EuiPageTemplate.Header>
<EuiSpacer size="m" />
<TextBasedLangEditor
query={localQuery}
onTextLangQueryChange={onTextLangQueryChange}
onTextLangQuerySubmit={onTextLangQuerySubmit}
detectedTimestamp={currentDataView?.timeFieldName}
hideRunQueryText={false}
isLoading={queryHistoryStatus ?? false}
/>
<EuiFlexItem
grow={false}
data-test-subj="DataVisualizerESQLEditor"
css={css({
borderTop: euiTheme.euiBorderThin,
borderLeft: euiTheme.euiBorderThin,
borderRight: euiTheme.euiBorderThin,
})}
>
<TextBasedLangEditor
query={localQuery}
onTextLangQueryChange={onTextLangQueryChange}
onTextLangQuerySubmit={onTextLangQuerySubmit}
detectedTimestamp={currentDataView?.timeFieldName}
hideRunQueryText={false}
isLoading={queryHistoryStatus ?? false}
/>
</EuiFlexItem>

<EuiFlexGroup gutterSize="m" direction={isWithinLargeBreakpoint ? 'column' : 'row'}>
<EuiFlexItem>
Expand Down