[EDR Workflows][Osquery] Fix last results pack value #192678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
commented
Sep 12, 2024
| const dateTime = lastResultsData?.['@timestamp']; | ||
| if (!dateTime) return undefined; | ||
|
|
||
| return Array.isArray(dateTime) ? dateTime[0] : dateTime; |
There was a problem hiding this comment.
It was reported that this issue is a regression. As a result, I’ve accounted for the possibility that some stack versions might return the search aggregation as a string rather than an array of strings.
gergoabraham
approved these changes
Sep 16, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
@szwarckonrad this pull request has an |
szwarckonrad
added
backport:version
Added |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
The “Last Results” tab in the active pack details is displaying incorrect date-time values. This is due to a mismatch in data format. The component responsible for formatting the date-time values expects a string, but it is currently receiving an array with a single string inside. Before:  After:  (cherry picked from commit cfcb6e8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…193579) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows][Osquery] Fix last results pack value (#192678)](#192678) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T08:18:09Z","message":"[EDR Workflows][Osquery] Fix last results pack value (#192678)\n\nThe “Last Results” tab in the active pack details is displaying\r\nincorrect date-time values. This is due to a mismatch in data format.\r\nThe component responsible for formatting the date-time values expects a\r\nstring, but it is currently receiving an array with a single string\r\ninside.\r\n\r\nBefore:\r\n\r\n\r\n\r\nAfter: \r\n\r\n","sha":"cfcb6e8f4ddf078ccdcec2a03788e39c6e4dfdef","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version"],"title":"[EDR Workflows][Osquery] Fix last results pack value","number":192678,"url":"https://github.com/elastic/kibana/pull/192678","mergeCommit":{"message":"[EDR Workflows][Osquery] Fix last results pack value (#192678)\n\nThe “Last Results” tab in the active pack details is displaying\r\nincorrect date-time values. This is due to a mismatch in data format.\r\nThe component responsible for formatting the date-time values expects a\r\nstring, but it is currently receiving an array with a single string\r\ninside.\r\n\r\nBefore:\r\n\r\n\r\n\r\nAfter: \r\n\r\n","sha":"cfcb6e8f4ddf078ccdcec2a03788e39c6e4dfdef"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192678","number":192678,"mergeCommit":{"message":"[EDR Workflows][Osquery] Fix last results pack value (#192678)\n\nThe “Last Results” tab in the active pack details is displaying\r\nincorrect date-time values. This is due to a mismatch in data format.\r\nThe component responsible for formatting the date-time values expects a\r\nstring, but it is currently receiving an array with a single string\r\ninside.\r\n\r\nBefore:\r\n\r\n\r\n\r\nAfter: \r\n\r\n","sha":"cfcb6e8f4ddf078ccdcec2a03788e39c6e4dfdef"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “Last Results” tab in the active pack details is displaying incorrect date-time values. This is due to a mismatch in data format. The component responsible for formatting the date-time values expects a string, but it is currently receiving an array with a single string inside.
Before:
After: