Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Remove extra overview route #192449

Merged
merged 22 commits into from
Sep 23, 2024
Merged

[Synthetics] Remove extra overview route #192449

merged 22 commits into from
Sep 23, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 10, 2024 •
edited by kibanamachine
Loading

Summary

Remove extra overview route !!

Testing

Test overview page with filters and paging etc

image

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 10, 2024
@shahzad31 shahzad31 marked this pull request as ready for review September 10, 2024 12:51
@shahzad31 shahzad31 requested a review from a team as a code owner September 10, 2024 12:51
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Sep 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

justinkambic
justinkambic requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try running these changes locally (against a dev location) I don't see any monitors show up in the overview page.

Step to repro this is:

  1. Create a monitor
  2. Go to the overview page
  3. See no monitors

Tested this by creating monitors on main and checking out this branch. Are we filtering unmanaged location monitors in someplace where we shouldn't be here?

...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx Outdated Show resolved Hide resolved
...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx Outdated Show resolved Hide resolved
...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx Outdated Show resolved Hide resolved
...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx Outdated Show resolved Hide resolved
...ics/public/apps/synthetics/components/monitors_page/overview/overview/use_infinite_scroll.ts Outdated Show resolved Hide resolved
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner September 19, 2024 12:11
@shahzad31 shahzad31 added the backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development label Sep 19, 2024
@shahzad31 shahzad31 removed the request for review from a team September 19, 2024 13:11
justinkambic
justinkambic requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some strange behavior in the overview grid as it relates to pending monitors:

On this PR branch

image

ON main

image

justinkambic
justinkambic approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/detail_flyout.ts Show resolved Hide resolved
...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 073a4d6
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192449-073a4d6fe8d2

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 965.1KB 963.3KB -1.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 721 720 -1
synthetics 52 51 -1
total -2

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 745 744 -1
synthetics 58 57 -1
total -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 5fcc495 into elastic:main Sep 23, 2024
31 checks passed
@shahzad31 shahzad31 deleted the remove-extra-overview branch September 23, 2024 13:09
@shahzad31 shahzad31 removed the backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development label Sep 23, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 23, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
@shahzad31
[Synthetics] Remove extra overview route (elastic#192449)
5058258 
## Summary

Remove extra overview route !!

### Testing
Test overview page with filters and paging etc

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/a64f7c04-f834-4496-a377-b8bd74542d21">

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 5fcc495)
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Synthetics] Fix heatmap on monitor detail/history page for very large doc counts (#184177)
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 192449

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Sep 23, 2024
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
@weizijun
Merge branch 'main' into add-alibaba-inference
2100828 
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
kibanamachine added a commit that referenced this pull request Sep 23, 2024
@kibanamachine @shahzad31
[8.x] [Synthetics] Remove extra overview route (#192449) (#193720)
fc0f5fe 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Remove extra overview route
(#192449)](#192449)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T13:09:13Z","message":"[Synthetics]
Remove extra overview route (#192449)\n\n## Summary\r\n\r\nRemove extra
overview route !!\r\n\r\n### Testing\r\nTest overview page with filters
and paging etc \r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a64f7c04-f834-4496-a377-b8bd74542d21\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5fcc495ae9875b94d0d7748bf0c078445c74e1ca","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Remove extra overview
route","number":192449,"url":"https://github.com/elastic/kibana/pull/192449","mergeCommit":{"message":"[Synthetics]
Remove extra overview route (#192449)\n\n## Summary\r\n\r\nRemove extra
overview route !!\r\n\r\n### Testing\r\nTest overview page with filters
and paging etc \r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a64f7c04-f834-4496-a377-b8bd74542d21\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5fcc495ae9875b94d0d7748bf0c078445c74e1ca"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192449","number":192449,"mergeCommit":{"message":"[Synthetics]
Remove extra overview route (#192449)\n\n## Summary\r\n\r\nRemove extra
overview route !!\r\n\r\n### Testing\r\nTest overview page with filters
and paging etc \r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a64f7c04-f834-4496-a377-b8bd74542d21\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5fcc495ae9875b94d0d7748bf0c078445c74e1ca"}}]}]
BACKPORT-->

---------

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @obltmachine @elasticmachine @kibana-ci @kibanamachine @justinkambic