Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Serverless Security: Adds ES|QL visualizer menu item in nav #192314

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[ML] Serverless Security: Adds ES|QL visualizer menu item in nav #192314

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
220c908
add esql data visualizer to security nav
alvarezmelissa87 Sep 7, 2024
8d91706
Merge branch 'main' into ml-esql-vis-to-security-nav
alvarezmelissa87 Sep 11, 2024
209fbfc
esql datavis should come before data drift. order changed
alvarezmelissa87 Sep 12, 2024
ce290c7
Merge branch 'main' into ml-esql-vis-to-security-nav
elasticmachine Sep 16, 2024
b377b04
update esql viz icon
alvarezmelissa87 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/packages/security-solution/navigation/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export enum ExternalPageName {
mlNodes = 'ml:nodes',
mlFileUpload = 'ml:fileUpload',
mlIndexDataVisualizer = 'ml:indexDataVisualizer',
mlESQLdataVisualizer = 'ml:esqlDataVisualizer',
mlDataDrift = 'ml:dataDrift',
mlExplainLogRateSpikes = 'ml:logRateAnalysis',
mlLogPatternAnalysis = 'ml:logPatternAnalysis',
Expand Down
7 changes: 7 additions & 0 deletions x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export const mlNavCategories: SolutionLinkCategory[] = [
linkIds: [
ExternalPageName.mlFileUpload,
ExternalPageName.mlIndexDataVisualizer,
ExternalPageName.mlESQLdataVisualizer,
peteharverson marked this conversation as resolved.
Show resolved Hide resolved
ExternalPageName.mlDataDrift,
],
},
Expand Down Expand Up @@ -186,6 +187,12 @@ export const mlNavLinks: SolutionNavLink[] = [
landingIcon: IconDataViewLazy,
description: i18n.INDEX_DATA_VISUALIZER_DESC,
},
{
id: ExternalPageName.mlESQLdataVisualizer,
title: i18n.ESQL_DATA_VISUALIZER_TITLE,
landingIcon: IconDataViewLazy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - is there a different icon we could use here to differentiate it from the data view data visualizer icon?

eui have this sqlApp icon for example, but I don't know if there is something similar from the icon set used by the security nav?

Screenshot 2024-09-12 at 10 52 42

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reached out regarding this question and will update once I have an update.

Copy link

@bojanasan bojanasan Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JasonStoltz @yanwalton, would you be able to suggest an icon that we could use here? There is a duplicate icon because the mocks are using the one indicated for the Data visualizer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvarezmelissa87 @peteharverson I think it makes sense to go with the sqlApp icon for now. If it needs to be swapped out later, it can be, but I think it make sense to use one of the duotone icons to keep it consistent.

cc @MichaelMarcialis @ryankeairns

Copy link
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon has been updated to 'sqlApp' and the screenshots in the description have been updated. 🙏 cc @bojanasan

description: i18n.ESQL_DATA_VISUALIZER_DESC,
},
{
id: ExternalPageName.mlDataDrift,
title: i18n.DATA_DRIFT_TITLE,
Expand Down
12 changes: 12 additions & 0 deletions ...lugins/security_solution/public/app/solution_navigation/links/sections/ml_translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,18 @@ export const INDEX_DATA_VISUALIZER_DESC = i18n.translate(
defaultMessage: 'Data view data visualizer page',
}
);
export const ESQL_DATA_VISUALIZER_TITLE = i18n.translate(
'xpack.securitySolution.navLinks.ml.esqlDataVisualizer.title',
{
defaultMessage: 'ES|QL data visualizer',
}
);
export const ESQL_DATA_VISUALIZER_DESC = i18n.translate(
'xpack.securitySolution.navLinks.ml.esqlDataVisualizer.desc',
{
defaultMessage: 'ES|QL data visualizer page',
}
);
export const DATA_DRIFT_TITLE = i18n.translate(
'xpack.securitySolution.navLinks.ml.dataDrift.title',
{
Expand Down