-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM][Otel] Add Otel client based on PoC data #192293
[APM][Otel] Add Otel client based on PoC data #192293
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
6013cb3
to
5c95114
Compare
…est-with-otel-data
…el-data' of https://github.com/jennypavlova/kibana into 192115-apmotel-add-synthtrace-scenarios-to-test-with-otel-data
…est-with-otel-data
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
@gregkalapos can you review this PR and check that the fields and everything looks good, @jennypavlova and I used the Otel documents on the POC as a source of truth but just to double-check 🙏 |
eeaa2c1
to
832abf1
Compare
…est-with-otel-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟
Thanks for the team work 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some findings below regarding fields.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
|
Closes #192115
Closes #192465
Summary
This PR adds synthrace client for Otel native data and a simple scenario. This is the first step of adding it and in the future it will include more metrics and use cases.
Note
To run ES the command needs "xpack.otel_data.registry.enabled=true" flag
yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true"
Next steps
service_destination
in the metrics indices we can include the other types in the futureTesting
yarn es snapshot --license trial --E "xpack.otel_data.registry.enabled=true"
Warning
If the e2e PoC is used the first 2 steps should be skipped
Warning
Currently the UI changes done in APM are not merged so some errors are expected)
Screen.Recording.2024-10-07.at.20.52.34.mov