[Logs] Remove AI Assistant specific log index setting #192003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Kerry350
added
Team:obs-ux-logs
|
/ci |
Kerry350
force-pushed
the
167-consolidate-obs-ai-assistant-settings
branch
from
a1c2482 to
0de226a
Compare
|
/ci |
1 similar comment
|
/ci |
Kerry350
force-pushed
the
167-consolidate-obs-ai-assistant-settings
branch
from
0df4829 to
6238809
Compare
|
/ci |
Kerry350
force-pushed
the
167-consolidate-obs-ai-assistant-settings
branch
from
02ffe2a to
695999f
Compare
|
/ci |
…s setting. Register log sources setting in serverless.
Kerry350
force-pushed
the
167-consolidate-obs-ai-assistant-settings
branch
from
695999f to
0e7ab20
Compare
|
/ci |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
|
@elasticmachine merge upstream |
botelastic
bot
added
ci:project-deploy-observability
shahzad31
approved these changes
Sep 9, 2024
|
@elasticmachine merge upstream |
|
Similar to the way Logs settings does not allow editing of the Logs Sources advanced setting it renders and is read only, I think it might be confusing to have it editable in the AI Assistant settings. I think these settings are for AI Assistant only and not affecting other apps. I'd prefer to follow the same UX as Logs settings and have it read only with a link. I think the "disabled" attribute might be better as it has the grey background and is clear its not editable, eg: 
|
Agree, let's disable it there. |
…-ai-assistant-settings
sebelga
approved these changes
Sep 16, 2024
…m:Kerry350/kibana into 167-consolidate-obs-ai-assistant-settings
|
@neptunian Thanks for reviewing. I've copied the behaviour from the logs UI settings page (this is now a shared component from logs data access). Should be good for another look 👍 AI Assistant settings:
Logs UI:
|
neptunian
approved these changes
Sep 16, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @Kerry350 |
kibanamachine
added
v9.0.0
backport:skip
|
@Kerry350 can you check if this needs to be backported to 8.x? |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Sep 23, 2024
## Summary Closes elastic/logs-dev#167. - Removes registration of the AI Assistant specific advanced setting (`observability:aiAssistantLogsIndexPattern`). - Replaces the setting with use of the central log sources setting (`observability:logSources`). - ℹ️ Also registers the central log sources setting in serverless (this was missed previously). Due to the impact that this setting has on alerts ([Discussion](elastic/logs-dev#170 (comment))) a migration path from one setting to the other isn't really possible, as values from the AI Assistant setting could potentially cause unwanted alerts. As such these changes opt for the route that we'll do a straight swap, and document this in release notes. We will also need to do a migration on the `config` (for advanced settings) Saved Object to remove instances of the old setting / property. With the new "model version" migration model [my understanding is this should happen in a separate followup PR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).⚠️ ~One potentially open question is whether the custom management section that the AI Assistant mounts when clicking "AI Assistant Settings" should render the log sources setting? (As this setting affects more than just the AI Assistant).~ [Resolved](elastic#192003 (comment))  --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit ebe4686) # Conflicts: # packages/serverless/settings/observability_project/index.ts
Kerry350
added a commit
that referenced
this pull request
Sep 24, 2024
…#193723) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Remove AI Assistant specific log index setting (#192003)](#192003) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T13:26:54Z","message":"[Logs] Remove AI Assistant specific log index setting (#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","backport:skip","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","apm:review"],"number":192003,"url":"https://github.com/elastic/kibana/pull/192003","mergeCommit":{"message":"[Logs] Remove AI Assistant specific log index setting (#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192003","number":192003,"mergeCommit":{"message":"[Logs] Remove AI Assistant specific log index setting (#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/logs-dev/issues/167.
observability:aiAssistantLogsIndexPattern).observability:logSources).Due to the impact that this setting has on alerts (Discussion) a migration path from one setting to the other isn't really possible, as values from the AI Assistant setting could potentially cause unwanted alerts. As such these changes opt for the route that we'll do a straight swap, and document this in release notes.
We will also need to do a migration on the
config(for advanced settings) Saved Object to remove instances of the old setting / property. With the new "model version" migration model my understanding is this should happen in a separate followup PR.One potentially open question is whether the custom management section that the AI Assistant mounts when clicking "AI Assistant Settings" should render the log sources setting? (As this setting affects more than just the AI Assistant).Resolved