Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Connectors] Highlight step as optional in connector creation form #191918

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Sep 2, 2024

Summary

I have added the (optional) text to step 4 of the Webhook - Case management creation form.

Before

before

After

Screenshot 2024-09-02 at 14 32 39

@adcoelho adcoelho added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Sep 2, 2024
@adcoelho adcoelho self-assigned this Sep 2, 2024
@adcoelho adcoelho requested a review from a team as a code owner September 2, 2024 13:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@adcoelho adcoelho added the release_note:skip Skip the PR/issue when compiling release notes label Sep 2, 2024
@joana-cps
Copy link

joana-cps commented Sep 2, 2024

@mdefazio @MichaelMarcialis @kyrspl

I was looking for pattern guidance on this and found this issue #195048.
I saw the conclusions there, but what would you recommend to do in this case?

All fields inside Add comment in case section are optional, and the idea was to add the label (optional) to the title, as @adcoelho mentioned, since we are using the labelAppend as Add variable link.
Image

Can you give me a recommendation here for consistency's sake?

@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Sep 3, 2024

Rather than adding "(optional)" text, my first instinct here would be to change the "Add comment in case" header to a togglable element, like an EuiSwitch. When the switch is off, all of the form elements in that section are hidden. When the switch is on, all of the form elements in that section are visible. The assumption then would be that if the switch is on and the form elements are visible, then they are all required.

@joana-cps
Copy link

joana-cps commented Sep 4, 2024

It's a good idea @MichaelMarcialis and makes a lot of sense in this flow.

@adcoelho as agreed, please substitute the header to an EuiSwitch. Should look like this (same for the edit flow):
Screenshot 2024-09-04 at 10 00 06

Feel free to merge this as an interim version and add the toggle version later on.

cc: @cnasikas

@adcoelho
Copy link
Contributor Author

adcoelho commented Sep 5, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 580.2KB 580.3KB +33.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit c6dce58 into elastic:main Sep 6, 2024
20 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants