[UII] Fix client-side validation for agent policy timeout fields #191674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Aug 29, 2024
…stic#191674) ## Summary Resolves elastic#191583. Adjusts the client-side validation for agent policy timeout fields so that it correctly returns an error when non-numeric input is encountered, or when input is 0. (cherry picked from commit f29bf1c) # Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jen-huang
added a commit
that referenced
this pull request
Aug 29, 2024
…ds (#191674) (#191752) # Backport This will backport the following commits from `main` to `8.15`: - [[UII] Fix client-side validation for agent policy timeout fields (#191674)](#191674) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-28T21:05:11Z","message":"[UII] Fix client-side validation for agent policy timeout fields (#191674)\n\n## Summary\r\n\r\nResolves #191583. Adjusts the client-side validation for agent policy\r\ntimeout fields so that it correctly returns an error when non-numeric\r\ninput is encountered, or when input is 0.","sha":"f29bf1c3113de90fc0ca08bf7a59a33d53638940","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"number":191674,"url":"https://github.com/elastic/kibana/pull/191674","mergeCommit":{"message":"[UII] Fix client-side validation for agent policy timeout fields (#191674)\n\n## Summary\r\n\r\nResolves #191583. Adjusts the client-side validation for agent policy\r\ntimeout fields so that it correctly returns an error when non-numeric\r\ninput is encountered, or when input is 0.","sha":"f29bf1c3113de90fc0ca08bf7a59a33d53638940"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191674","number":191674,"mergeCommit":{"message":"[UII] Fix client-side validation for agent policy timeout fields (#191674)\n\n## Summary\r\n\r\nResolves #191583. Adjusts the client-side validation for agent policy\r\ntimeout fields so that it correctly returns an error when non-numeric\r\ninput is encountered, or when input is 0.","sha":"f29bf1c3113de90fc0ca08bf7a59a33d53638940"}}]}] BACKPORT-->
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Sep 27, 2024
…lds (elastic#191674)" This reverts commit f29bf1c.
jen-huang
added a commit
that referenced
this pull request
Sep 30, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…lds (elastic#191674)" (elastic#194338) ## Summary Resolves elastic#194221. This PR reverts commit f29bf1c. Timeout fields should be clearable with undefined value or zero. (cherry picked from commit 6792cb4)
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…timeout fields (#191674)" (#194338) (#194491) # Backport This will backport the following commits from `main` to `8.x`: - [Revert "[UII] Fix client-side validation for agent policy timeout fields (#191674)" (#194338)](#194338) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T21:22:37Z","message":"Revert \"[UII] Fix client-side validation for agent policy timeout fields (#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis PR reverts commit f29bf1c. Timeout\r\nfields should be clearable with undefined value or zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[UII] Fix client-side validation for agent policy timeout fields (#191674)\"","number":194338,"url":"https://github.com/elastic/kibana/pull/194338","mergeCommit":{"message":"Revert \"[UII] Fix client-side validation for agent policy timeout fields (#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis PR reverts commit f29bf1c. Timeout\r\nfields should be clearable with undefined value or zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194338","number":194338,"mergeCommit":{"message":"Revert \"[UII] Fix client-side validation for agent policy timeout fields (#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis PR reverts commit f29bf1c. Timeout\r\nfields should be clearable with undefined value or zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #191583. Adjusts the client-side validation for agent policy timeout fields so that it correctly returns an error when non-numeric input is encountered, or when input is 0.