Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] persist refresh interval in local storage #191333

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 27, 2024

Summary

Stores refresh interval and refresh paused state in local storage.

Also defaults refresh to paused rather than active.

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dominiqueclarke
Copy link
Contributor Author

/ci

@dominiqueclarke
Copy link
Contributor Author

/ci

@dominiqueclarke
Copy link
Contributor Author

/ci

@dominiqueclarke dominiqueclarke changed the title synthetics - persist refresh interval in local storage [Synthetics] persist refresh interval in local storage Sep 9, 2024
@dominiqueclarke dominiqueclarke added Team:obs-ux-management Observability Management User Experience Team release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Sep 9, 2024
@dominiqueclarke dominiqueclarke marked this pull request as ready for review September 9, 2024 20:15
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner September 9, 2024 20:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 10, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 16, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 9a020be
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191333-9a020bef2350

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1020 1018 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 964.2KB 963.4KB -818.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@dominiqueclarke dominiqueclarke merged commit 3ad697b into elastic:main Sep 16, 2024
26 checks passed
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-persist-refresh-interval branch September 16, 2024 16:20
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2024
## Summary

Stores refresh interval and refresh paused state in local storage.

Also defaults refresh to paused rather than active.

---------

Co-authored-by: Shahzad <[email protected]>
(cherry picked from commit 3ad697b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 16, 2024
#193054)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] persist refresh interval in local storage
(#191333)](#191333)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T16:20:33Z","message":"[Synthetics]
persist refresh interval in local storage (#191333)\n\n##
Summary\r\n\r\nStores refresh interval and refresh paused state in local
storage.\r\n\r\nAlso defaults refresh to paused rather than
active.\r\n\r\n---------\r\n\r\nCo-authored-by: Shahzad
<[email protected]>","sha":"3ad697b74fdf09049464c4a7a8f2cd44550709f0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"[Synthetics]
persist refresh interval in local
storage","number":191333,"url":"https://github.com/elastic/kibana/pull/191333","mergeCommit":{"message":"[Synthetics]
persist refresh interval in local storage (#191333)\n\n##
Summary\r\n\r\nStores refresh interval and refresh paused state in local
storage.\r\n\r\nAlso defaults refresh to paused rather than
active.\r\n\r\n---------\r\n\r\nCo-authored-by: Shahzad
<[email protected]>","sha":"3ad697b74fdf09049464c4a7a8f2cd44550709f0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191333","number":191333,"mergeCommit":{"message":"[Synthetics]
persist refresh interval in local storage (#191333)\n\n##
Summary\r\n\r\nStores refresh interval and refresh paused state in local
storage.\r\n\r\nAlso defaults refresh to paused rather than
active.\r\n\r\n---------\r\n\r\nCo-authored-by: Shahzad
<[email protected]>","sha":"3ad697b74fdf09049464c4a7a8f2cd44550709f0"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants