[MX] Fix flaky tests for severity component #191202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guskovaue
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @guskovaue |
jcger
approved these changes
Aug 26, 2024
|
@jcger Yes, I used test.each(Array(100).fill(null)(test)) for this purpose. Unfortunately the framework we used for flakiness detection works only for functional tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #188951
Fix flaky test: x-pack/plugins/cases/public/components/case_form_fields/severity.test.tsx
It seems that this wrapper
createAppMockRendereris very slow. But we do not need it for this small and simple component. So I just deleted it from the test and use commonrenderinstead.