Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix the memory usage chart visibility in the Nodes overview table #190981

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Aug 21, 2024

Summary

Fixes the memory usage chart visibility in the Nodes overview table

Checklist

@darnautov darnautov requested a review from a team as a code owner August 21, 2024 12:51
@darnautov darnautov added the :ml label Aug 21, 2024
@darnautov darnautov self-assigned this Aug 21, 2024
@darnautov darnautov added release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.16.0 labels Aug 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) August 26, 2024 12:49
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / Use get case configuration hook returns the initial configuration if none exists
  • [job] [logs] FTR Configs #98 / Visualizations - Group 3 lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit b0beec1 into elastic:main Aug 26, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 26, 2024
@darnautov darnautov deleted the ml-fix-memory-overview-chart branch September 10, 2024 10:12
@darnautov darnautov added v8.15.2 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Sep 20, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2024
elastic#190981)

## Summary

Fixes the memory usage chart visibility in the Nodes overview table

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit b0beec1)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15
8.x Cherrypick failed because the selected commit (b0beec1) is empty. Did you already backport this commit?

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 190981

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2024
…ew table (#190981) (#193566)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Fix the memory usage chart visibility in the Nodes overview
table (#190981)](#190981)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-26T14:30:58Z","message":"[ML]
Fix the memory usage chart visibility in the Nodes overview table
(#190981)\n\n## Summary\r\n\r\nFixes the memory usage chart visibility
in the Nodes overview table \r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"b0beec1608f40b3b00f0aaaf40364cc03d822a61","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","backport:prev-minor","v8.16.0","v8.15.2"],"title":"[ML]
Fix the memory usage chart visibility in the Nodes overview table
","number":190981,"url":"https://github.com/elastic/kibana/pull/190981","mergeCommit":{"message":"[ML]
Fix the memory usage chart visibility in the Nodes overview table
(#190981)\n\n## Summary\r\n\r\nFixes the memory usage chart visibility
in the Nodes overview table \r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"b0beec1608f40b3b00f0aaaf40364cc03d822a61"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190981","number":190981,"mergeCommit":{"message":"[ML]
Fix the memory usage chart visibility in the Nodes overview table
(#190981)\n\n## Summary\r\n\r\nFixes the memory usage chart visibility
in the Nodes overview table \r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"b0beec1608f40b3b00f0aaaf40364cc03d822a61"}},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.15.2 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants