[ES|QL] Auto open suggestions for field lists

[drewdaemon]

Summary

Part of #189662

Suggests comma and pipe

Screen.Recording.2024-08-06.at.5.09.58.PM.mov

Doesn't suggest comma when there are no more fields

Screen.Recording.2024-08-22.at.9.35.51.AM.mov

Doesn't work for escaped columns :(

Screen.Recording.2024-08-22.at.9.38.16.AM.mov

As part of this effort I discovered #191100 and #191105, as well as a problem with column name validation (see #177699)

I think we can revisit column escaping and probably resolve all of these issues (issue here).

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[drewdaemon]

Blocked on #190465

[drewdaemon]

/ci

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 8a6733c

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
securitySolution	5674	5675	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/esql-validation-autocomplete	183	184	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	18.0MB	18.0MB	-12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-srcJs	3.3MB	3.3MB	+883.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/esql-validation-autocomplete	195	196	+1

History

• 💛 Build #229197 was flaky 8a6733c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ryankeairns]

Gave it a go, felt good, and work as described!

Also, nice finds on those other issues.

[qn895]

Nice!

[qn895]

Looking at this again, will there ever be a case where we can not remove the last [] in the text to get the singular type? Do we need to look up a map for it?

[drewdaemon]

We could always just remove the [] through string manipulation. I like the map because it makes it clear which types can be arrays. I guess this whole array types thing makes me nervous because I don't have a good handle yet on its purpose. So, I like being a bit more explicit.

Open to opinions though.

[qn895]

Tested and LGTM 🎉