Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KibanaErrorBoundary] Log the error that was caught #189925

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[KibanaErrorBoundary] Log the error that was caught #189925

merged 1 commit into from
Aug 6, 2024

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Aug 5, 2024 •
edited
Loading

Log the error that was caught to the console, so developers can interact with the stack trace messages.

Addresses #168754 (comment)

@tsullivan tsullivan self-assigned this Aug 5, 2024
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 5, 2024
@tsullivan tsullivan mentioned this pull request Aug 5, 2024
Merged
8 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +78.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/shared-ux-error-boundary 2 4 +2

Total ESLint disabled count

id before after diff
@kbn/shared-ux-error-boundary 2 4 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

@tsullivan tsullivan marked this pull request as ready for review August 5, 2024 23:33
@tsullivan tsullivan requested a review from a team as a code owner August 5, 2024 23:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Aug 5, 2024
Dosant
Dosant approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sorenlouv
sorenlouv approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Much appreciated!!

@tsullivan tsullivan merged commit 6b4f613 into elastic:main Aug 6, 2024
27 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@tsullivan tsullivan

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tsullivan @kibana-ci @elasticmachine @sorenlouv @Dosant @kibanamachine