[CI] Archive logs from yarn es docker runs
#189231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt up - this still misses the last occasion when a run finishes
This reverts commit e056c18.
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
| '--format', | ||
| '{{.Names}}', | ||
| ]); | ||
| nodeNames = nodeNamesString.split('\n').filter(Boolean); |
Ikuni17
reviewed
Sep 12, 2024
delanni
added
backport:prev-major
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Ikuni17
approved these changes
Sep 13, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2024
## Summary The problem we're trying to solve here is to get access to `elasticsearch-serverless` logs when they're started in docker containers in the background (and `elasticsearch`, although currently we don't test against that in docker for now). ## Solution In essence: - we needed to remove the `--rm` flag, this would allow for the containers to stay present after they're done. - after this, we can run `docker logs ...` on FTR post-hooks, save these, then archive these files to buildkite - because the containers are not removed upon finishing, we need to clean up dangling containers before starting up Backporting is probably not necessary, because this is only applicable for serverless - and serverless is only supposed to run on main. Solves: elastic#191505 (cherry picked from commit bce4a17)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2024
## Summary The problem we're trying to solve here is to get access to `elasticsearch-serverless` logs when they're started in docker containers in the background (and `elasticsearch`, although currently we don't test against that in docker for now). ## Solution In essence: - we needed to remove the `--rm` flag, this would allow for the containers to stay present after they're done. - after this, we can run `docker logs ...` on FTR post-hooks, save these, then archive these files to buildkite - because the containers are not removed upon finishing, we need to clean up dangling containers before starting up Backporting is probably not necessary, because this is only applicable for serverless - and serverless is only supposed to run on main. Solves: elastic#191505 (cherry picked from commit bce4a17)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2024
#192973) # Backport This will backport the following commits from `main` to `8.x`: - [[CI] Archive logs from `yarn es` docker runs (#189231)](#189231) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T08:43:12Z","message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[CI] Archive logs from `yarn es` docker runs","number":189231,"url":"https://github.com/elastic/kibana/pull/189231","mergeCommit":{"message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189231","number":189231,"mergeCommit":{"message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2024
… (#192972) # Backport This will backport the following commits from `main` to `8.15`: - [[CI] Archive logs from `yarn es` docker runs (#189231)](#189231) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T08:43:12Z","message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[CI] Archive logs from `yarn es` docker runs","number":189231,"url":"https://github.com/elastic/kibana/pull/189231","mergeCommit":{"message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189231","number":189231,"mergeCommit":{"message":"[CI] Archive logs from `yarn es` docker runs (#189231)\n\n## Summary\r\nThe problem we're trying to solve here is to get access to\r\n`elasticsearch-serverless` logs when they're started in docker\r\ncontainers in the background (and `elasticsearch`, although currently we\r\ndon't test against that in docker for now).\r\n## Solution\r\nIn essence:\r\n- we needed to remove the `--rm` flag, this would allow for the\r\ncontainers to stay present after they're done.\r\n- after this, we can run `docker logs ...` on FTR post-hooks, save\r\nthese, then archive these files to buildkite\r\n- because the containers are not removed upon finishing, we need to\r\nclean up dangling containers before starting up\r\n\r\nBackporting is probably not necessary, because this is only applicable\r\nfor serverless - and serverless is only supposed to run on main.\r\n\r\nSolves: https://github.com/elastic/kibana/issues/191505","sha":"bce4a17f088969621ade141a8d19ff3fcde833b0"}}]}] BACKPORT--> --------- Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Brad White <[email protected]>
kibanamachine
added
v8.15.3
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem we're trying to solve here is to get access to
elasticsearch-serverlesslogs when they're started in docker containers in the background (andelasticsearch, although currently we don't test against that in docker for now).Solution
In essence:
--rmflag, this would allow for the containers to stay present after they're done.docker logs ...on FTR post-hooks, save these, then archive these files to buildkiteBackporting is probably not necessary, because this is only applicable for serverless - and serverless is only supposed to run on main.
Solves: #191505
You can find the logs archived in the Artifacts tab of the buildkite step:
