Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Monaco] Improve color contrast of selection highlighting #189060

Merged

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Jul 24, 2024

Closes #186772

Summary

This PR fixes the color contrast issue with the selection highlighting in Console Monaco.

Before:
Screenshot 2024-07-24 at 12 49 09

Now:
Screenshot 2024-07-24 at 11 59 08

Note: I changed the request highlighting color from grey to blue (euiColorPrimary) since we are soon starting work on the Console redesign project, in which the new request highlighting color is blue (see screenshot from Figma project below). With the blue color, the contrast seems to be much higher.

Screenshot from Figma project Screenshot 2024-07-24 at 12 53 55

@ElenaStoeva ElenaStoeva self-assigned this Jul 24, 2024
@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Jul 24, 2024
@ElenaStoeva ElenaStoeva requested a review from a team July 24, 2024 11:56
@ElenaStoeva
Copy link
Contributor Author

/ci

@ElenaStoeva
Copy link
Contributor Author

/ci

@ElenaStoeva ElenaStoeva marked this pull request as ready for review July 25, 2024 17:00
@ElenaStoeva ElenaStoeva requested review from a team as code owners July 25, 2024 17:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva removed the request for review from a team July 25, 2024 17:01
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this up, huge QOL improvement its been bothering me for a while!

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) July 30, 2024 09:04
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 64c61e0 into elastic:main Jul 30, 2024
19 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console][Monaco] No contrast between selected text and current line colors
6 participants