Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip context navigation flaky tests #188811

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[Discover] Unskip context navigation flaky tests #188811

merged 2 commits into from
Jul 23, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jul 22, 2024
@jughosta jughosta self-assigned this Jul 22, 2024
@jughosta
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6601

[✅] test/functional/apps/context/config.ts: 25/25 tests passed.

see run history

@jughosta
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #99 / discover/group3 discover lens vis should show no histogram for non-time-based data views and recover for time-based data views

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review July 22, 2024 13:00
@jughosta jughosta requested a review from a team as a code owner July 22, 2024 13:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

davismcphee
davismcphee approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jughosta jughosta merged commit 9a44464 into elastic:main Jul 23, 2024
19 checks passed
@jughosta jughosta deleted the 188396-fix-context-tests branch July 23, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.16.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @kibana-ci @elasticmachine @davismcphee