yarn kbn reset will clean data/ as well to avoid stale state
#188298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
jbudz
approved these changes
Jul 15, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 15, 2024
…ic#188298) ## Summary In some cases, the `data/` folder sticking around is causing developers' environments to be corrupted. None of the current reset/clean methods clean that folder. This PR adds this small adjustment. Closes: elastic#187914 (cherry picked from commit f1fa221)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 15, 2024
…tale state (#188298) (#188316) # Backport This will backport the following commits from `main` to `8.15`: - [`yarn kbn reset` will clean data/ as well to avoid stale state (#188298)](#188298) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-15T14:38:57Z","message":"`yarn kbn reset` will clean data/ as well to avoid stale state (#188298)\n\n## Summary\r\nIn some cases, the `data/` folder sticking around is causing developers'\r\nenvironments to be corrupted. None of the current reset/clean methods\r\nclean that folder. This PR adds this small adjustment.\r\n\r\nCloses: https://github.com/elastic/kibana/issues/187914","sha":"f1fa22125115c13638e3470891f62fbbe02c71bb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.16.0"],"title":"`yarn kbn reset` will clean data/ as well to avoid stale state","number":188298,"url":"https://github.com/elastic/kibana/pull/188298","mergeCommit":{"message":"`yarn kbn reset` will clean data/ as well to avoid stale state (#188298)\n\n## Summary\r\nIn some cases, the `data/` folder sticking around is causing developers'\r\nenvironments to be corrupted. None of the current reset/clean methods\r\nclean that folder. This PR adds this small adjustment.\r\n\r\nCloses: https://github.com/elastic/kibana/issues/187914","sha":"f1fa22125115c13638e3470891f62fbbe02c71bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188298","number":188298,"mergeCommit":{"message":"`yarn kbn reset` will clean data/ as well to avoid stale state (#188298)\n\n## Summary\r\nIn some cases, the `data/` folder sticking around is causing developers'\r\nenvironments to be corrupted. None of the current reset/clean methods\r\nclean that folder. This PR adds this small adjustment.\r\n\r\nCloses: https://github.com/elastic/kibana/issues/187914","sha":"f1fa22125115c13638e3470891f62fbbe02c71bb"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <[email protected]>
|
@delanni just a note that in order to backport this into 7.17 we will have to change it here https://github.com/elastic/kibana/blob/7.17/packages/kbn-pm/src/commands/reset.ts |
delanni
added a commit
that referenced
this pull request
Jul 19, 2024
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
## Summary Manual backport of elastic#188298 Also deletes the data folder when `yarn kbn reset` is ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases, the
data/folder sticking around is causing developers' environments to be corrupted. None of the current reset/clean methods clean that folder. This PR adds this small adjustment.Closes: #187914