-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eem] top_value metadata aggregation #188243
[eem] top_value metadata aggregation #188243
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
/ci |
...lity_solution/entity_manager/server/lib/entities/transform/generate_metadata_aggregations.ts
Outdated
Show resolved
Hide resolved
@jaredburgettelastic @machadoum I've added a lookbackPeriod parameter to the aggregation - I'll merge now lmk if there's any follow up you'd like to add |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @klacabane |
@klacabane can you check if this need to be backported to 8.x? |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 1e6b13c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[eem] top_value metadata aggregation (#188243)](#188243) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T01:01:41Z","message":"[eem] top_value metadata aggregation (#188243)","sha":"1e6b13c8e0791d49a672e614d5117f3dee1b813c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Feature:EEM","team:obs-entities"],"title":"[eem] top_value metadata aggregation","number":188243,"url":"https://github.com/elastic/kibana/pull/188243","mergeCommit":{"message":"[eem] top_value metadata aggregation (#188243)","sha":"1e6b13c8e0791d49a672e614d5117f3dee1b813c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188243","number":188243,"mergeCommit":{"message":"[eem] top_value metadata aggregation (#188243)","sha":"1e6b13c8e0791d49a672e614d5117f3dee1b813c"}}]}] BACKPORT--> Co-authored-by: Kevin Lacabane <[email protected]>
Metadata fields currently supports
terms
aggregation only to retrieve a list of values.This change updates the metadata schema so one can define different aggregations and also implements a
top_value
agg that returns a single value according to a sort criteria.The
top_value
aggregation is limited to the single top value since transforms do not support multi values fortop_metrics
Usage: