Remove API doc workflow, add codeowners #188169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
lcawl
added
Feature:OAS
lcawl
added
v8.15.0
v8.16.0
and removed
backport:skip
jbudz
reviewed
Jul 15, 2024
jbudz
reviewed
Jul 15, 2024
|
@jbudz I would also double check the repo settings for https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#about-workflow-runs-from-public-forks. That way any invocation by an external contributor would require input from a maintainer. |
DaveSys911
reviewed
Jul 16, 2024
.github/workflows/bump-preview.yml
Outdated
| uses: bump-sh/github-action@v1 | ||
| with: | ||
| doc: serverless | ||
| token: ${{secrets.BUMP_TOKEN}} |
There was a problem hiding this comment.
@lcawl I believe this would fail when ran from forks. Since it won't have access to the secret.
There was a problem hiding this comment.
Since this PR doesn't seem to solve the problem, I've changed it to remove the existing problematic workflow instead.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
lcawl
changed the title
jbudz
approved these changes
Jul 17, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Jon <[email protected]> (cherry picked from commit 1a1c7d6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
that referenced
this pull request
Jul 17, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [Remove API doc workflow, add codeowners (#188169)](#188169) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-17T21:21:12Z","message":"Remove API doc workflow, add codeowners (#188169)\n\n\r\nCo-authored-by: Jon <[email protected]>","sha":"1a1c7d6101b32f9e84fbb39d7f10e0dcb1303ad5","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.15.0","Feature:OAS","v8.16.0"],"number":188169,"url":"https://github.com/elastic/kibana/pull/188169","mergeCommit":{"message":"Remove API doc workflow, add codeowners (#188169)\n\n\r\nCo-authored-by: Jon <[email protected]>","sha":"1a1c7d6101b32f9e84fbb39d7f10e0dcb1303ad5"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188169","number":188169,"mergeCommit":{"message":"Remove API doc workflow, add codeowners (#188169)\n\n\r\nCo-authored-by: Jon <[email protected]>","sha":"1a1c7d6101b32f9e84fbb39d7f10e0dcb1303ad5"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #186909
This PR: