[8.15] [Kibana logging system] Add conditional evaluation based on level for logging APIs (#187225) #187747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logging APIs (elastic#187225) ## Summary *(Yeah, the title is pretty bad I apologize, I couldn't find something sexy. OTOH, "sexy" and "logging" are usually antonyms, like "sport car" and "fiat panda", or "server language" and "javascript")* ### 1. Provide a more developer-friendly alternative to `Logger.isLevelEnabled`. **With `isLevelEnabled`** ```ts if(logger.isLevelEnabled('info')) { const message = someExpensiveMessageProbablyBasedOnJsonStringifyOrSomething(); logger.info(message); } ``` **With this PR:** ```ts logger.info(() => someExpensiveMessageProbablyBasedOnJsonStringifyOrSomething()); ``` ### 2. Adapt calls to `log.debug` (arguably) costly to use this syntax Aka any call relying on `JSON.stringify` or function calls. I used the new syntax for those, except when the tests were too complicated to fix or when the code did not allow it (e.g. untyped let variables infered from return from assignations don't play well with closures) (cherry picked from commit b6fcfac)
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Opened by mistake - closing |
auto-merge was automatically disabled
July 8, 2024 14:04
Pull request was closed
⏳ Build in-progress
Failed CI Steps
Historycc @pgayvallet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation