[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions #187517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent policies READ permissions
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jen-huang
reviewed
Jul 3, 2024
| @@ -144,8 +144,7 @@ export const calculateAuthz = ({ | |||
| // These are currently used by Fleet Server setup | |||
| setup: fleet.all || fleet.setup, | |||
| readEnrollmentTokens: (fleet.all || fleet.setup || fleet.agents?.all) ?? false, | |||
| readAgentPolicies: | |||
| (fleet.all || fleet.read || fleet.setup || fleet.agentPolicies?.read) ?? false, | |||
| readAgentPolicies: (fleet.all || fleet.setup) ?? false, | |||
There was a problem hiding this comment.
why is fleet.agentPolicies?.read removed here?
There was a problem hiding this comment.
This is the case where the feature flag subfeatureEnabled is not enabled, we should not check for subfeature privileges in that case
jen-huang
approved these changes
Jul 3, 2024
|
@elasticmachine merge upstream |
kibanamachine
added
v8.15.0
backport:skip
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @nchaulet |
nchaulet
deleted the
feature-disable-standalone-flyout-without-needed-permissions
branch
nchaulet
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 4, 2024
…ent policies READ permissions (elastic#187517) (cherry picked from commit c27ca40)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 4, 2024
…hout agent policies READ permissions (#187517) (#187605) # Backport This will backport the following commits from `main` to `8.15`: - [[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions (#187517)](#187517) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-04T13:45:20Z","message":"[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions (#187517)","sha":"c27ca409a4fcfa4a16e44558ab1302fa26f7f3b8","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions","number":187517,"url":"https://github.com/elastic/kibana/pull/187517","mergeCommit":{"message":"[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions (#187517)","sha":"c27ca409a4fcfa4a16e44558ab1302fa26f7f3b8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187517","number":187517,"mergeCommit":{"message":"[Fleet] Disable selecting standalone instructions for user without agent policies READ permissions (#187517)","sha":"c27ca409a4fcfa4a16e44558ab1302fa26f7f3b8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #184567
User without agent policies read cannot access the full agent policy, so cannot display the add standalone agent, that PR disable the switch (or tab) to display the add standalone agent instructions
UI changes