Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Enable anomaly charts Accessibility tests #187482

Merged
merged 5 commits into from
Jul 5, 2024
Merged

[ML] Enable anomaly charts Accessibility tests #187482

merged 5 commits into from
Jul 5, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jul 3, 2024 •
edited by kibanamachine
Loading

Summary

Closes #183196

Checklist

@darnautov
Copy link
Contributor Author

/ci

@peteharverson peteharverson mentioned this pull request Jul 3, 2024
Closed
13 tasks
@darnautov
Copy link
Contributor Author

/ci

@darnautov darnautov self-assigned this Jul 4, 2024
@darnautov
Copy link
Contributor Author

Flaky tests runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6468

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6468

[✅] x-pack/test/accessibility/apps/group3/config.ts: 50/50 tests passed.

see run history

peteharverson
peteharverson approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov marked this pull request as ready for review July 5, 2024 07:13
@darnautov darnautov requested a review from a team as a code owner July 5, 2024 07:13
darnautov
darnautov commented Jul 5, 2024
View reviewed changes
x-pack/test/accessibility/apps/group3/ml_embeddables_in_dashboard.ts
@@ -98,6 +97,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('can open job selection flyout', async () => {
await PageObjects.dashboard.clickCreateDashboardPrompt();
await ml.dashboardEmbeddables.assertDashboardIsEmpty();
// FIXME remove sleep when https://github.com/elastic/kibana/issues/187587 if fixed
await PageObjects.common.sleep(3000);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add sleep due to this bug. When it's fixed, we should replace this hardcoded delay and wait for the list initializaiton.

@darnautov darnautov added :ml Team:ML Team label for ML (also use :ml) labels Jul 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.16.0 test_ui_functional labels Jul 5, 2024
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) July 5, 2024 11:37
@darnautov darnautov merged commit 503cac3 into elastic:main Jul 5, 2024
18 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @darnautov

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2024
@darnautov
[ML] Enable anomaly charts Accessibility tests (elastic#187482)
2faecf7 
## Summary

Closes elastic#183196

### Checklist

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 503cac3)
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@darnautov darnautov deleted the ml-183196-enable-anomaly-charts-tests branch July 5, 2024 13:22
kibanamachine added a commit that referenced this pull request Jul 8, 2024
@kibanamachine @darnautov @elasticmachine
[8.15] [ML] Enable anomaly charts Accessibility tests (#187482) (#187675
7f96938 
)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Enable anomaly charts Accessibility tests
(#187482)](#187482)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T13:13:35Z","message":"[ML]
Enable anomaly charts Accessibility tests (#187482)\n\n##
Summary\r\n\r\nCloses #183196 \r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"503cac3127b85f54f6242033cc9154ba872050a7","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","Team:ML","v8.15.0","v8.16.0"],"title":"[ML]
Enable anomaly charts Accessibility tests
","number":187482,"url":"https://github.com/elastic/kibana/pull/187482","mergeCommit":{"message":"[ML]
Enable anomaly charts Accessibility tests (#187482)\n\n##
Summary\r\n\r\nCloses #183196 \r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"503cac3127b85f54f6242033cc9154ba872050a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187482","number":187482,"mergeCommit":{"message":"[ML]
Enable anomaly charts Accessibility tests (#187482)\n\n##
Summary\r\n\r\nCloses #183196 \r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"503cac3127b85f54f6242033cc9154ba872050a7"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
4 participants
@darnautov @kibanamachine @elasticmachine @peteharverson