Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Logs UI] Add constraint check (#186872) #187256

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[8.14] [Logs UI] Add constraint check (#186872) #187256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ...bility_solution/logs_shared/server/lib/adapters/log_entries/kibana_log_entries_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ import { TIMESTAMP_FIELD, TIEBREAKER_FIELD } from '../../../../common/constants'

const TIMESTAMP_FORMAT = 'epoch_millis';

const MAX_BUCKETS = 1000;

function getBucketIntervalStarts(
startTimestamp: number,
endTimestamp: number,
bucketSize: number
): Date[] {
// estimated number of buckets
const bucketCount = Math.ceil((endTimestamp - startTimestamp) / bucketSize);
if (bucketCount > MAX_BUCKETS) {
throw new Error(`Requested too many buckets: ${bucketCount} > ${MAX_BUCKETS}`);
}
return timeMilliseconds(new Date(startTimestamp), new Date(endTimestamp), bucketSize);
}

export class LogsSharedKibanaLogEntriesAdapter implements LogEntriesAdapter {
constructor(private readonly framework: KibanaFramework) {}

Expand Down Expand Up @@ -134,11 +149,7 @@ export class LogsSharedKibanaLogEntriesAdapter implements LogEntriesAdapter {
bucketSize: number,
filterQuery?: LogEntryQuery
): Promise<LogSummaryBucket[]> {
const bucketIntervalStarts = timeMilliseconds(
new Date(startTimestamp),
new Date(endTimestamp),
bucketSize
);
const bucketIntervalStarts = getBucketIntervalStarts(startTimestamp, endTimestamp, bucketSize);

const query = {
allow_no_indices: true,
Expand Down
Loading