Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump.sh diff adjustments #186909

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −11
Open

Bump.sh diff adjustments #186909

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac1bdc0
[CI / OAS] Use 'pull_request_target' for Bump action
paulRbr Jun 25, 2024
c6e9886
[CI / OAS] Remove extra API documentation preview
paulRbr Jun 25, 2024
d7c6c3d
Merge branch 'main' into bump-diff-ajustements
lcawl Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
paths:
- 'oas_docs/kibana.serverless.yaml'

pull_request:
pull_request_target:
paulRbr marked this conversation as resolved.
Show resolved Hide resolved
branches:
- main
paths:
Expand All @@ -33,21 +33,12 @@ jobs:
file: oas_docs/kibana.serverless.yaml

api-diff:
if: ${{ github.event_name == 'pull_request' }}
paulRbr marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ github.event_name == 'pull_request_target' }}
name: Check API diff on Bump.sh
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Create Preview
uses: bump-sh/github-action@v1
with:
doc: serverless
token: ${{secrets.BUMP_TOKEN}}
file: oas_docs/kibana.serverless.yaml
command: preview
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
- name: Comment pull request with API diff
uses: bump-sh/github-action@v1
with:
Expand Down