Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert styled-component usage to Emotion vanilla CSS #186849

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jun 24, 2024

Summary

Follow up to 9125e17 - move away from using euiStyled (which throws errors if plugin(s) using the component aren't wrapped in KibanaStyledComponentsThemeProvider.

See EUI's Emotion FAQ for more information: elastic/eui#6828

Checklist

@cee-chen cee-chen changed the title Convert styled-components usage to Emotion vanilla CSS Convert styled-component usage to Emotion vanilla CSS Jun 24, 2024
@cee-chen
Copy link
Contributor Author

/ci

@cee-chen cee-chen requested a review from ersin-erdal June 24, 2024 19:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 761 764 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +6.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review June 24, 2024 21:35
@cee-chen cee-chen requested a review from a team as a code owner June 24, 2024 21:35
@cee-chen cee-chen added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jun 24, 2024
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cee-chen cee-chen merged commit 606c695 into elastic:main Jun 25, 2024
40 checks passed
@cee-chen cee-chen deleted the eui-styled-fix branch June 25, 2024 16:02
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants