Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Use more BUCKET() examples #186799

Merged

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Jun 24, 2024

Instead of using DATE_TRUNC, use BUCKET in bucketing examples. BUCKET is more appropriate for bucketing.

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.14.2 labels Jun 24, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner June 24, 2024 09:49
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Jun 24, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 24, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar self-assigned this Jun 24, 2024
@dgieselaar dgieselaar merged commit bf315d1 into elastic:main Jun 25, 2024
34 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 25, 2024
Instead of using DATE_TRUNC, use BUCKET in bucketing examples. BUCKET is
more appropriate for bucketing.

(cherry picked from commit bf315d1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 25, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI Assistant] Use more BUCKET() examples
(#186799)](#186799)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-25T06:39:42Z","message":"[Obs
AI Assistant] Use more BUCKET() examples (#186799)\n\nInstead of using
DATE_TRUNC, use BUCKET in bucketing examples. BUCKET is\r\nmore
appropriate for
bucketing.","sha":"bf315d162a35e74da063f4ec20f8105454d4b0ba","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs
AI
Assistant","ci:project-deploy-observability","v8.15.0","v8.14.2"],"title":"[Obs
AI Assistant] Use more BUCKET()
examples","number":186799,"url":"https://github.com/elastic/kibana/pull/186799","mergeCommit":{"message":"[Obs
AI Assistant] Use more BUCKET() examples (#186799)\n\nInstead of using
DATE_TRUNC, use BUCKET in bucketing examples. BUCKET is\r\nmore
appropriate for
bucketing.","sha":"bf315d162a35e74da063f4ec20f8105454d4b0ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186799","number":186799,"mergeCommit":{"message":"[Obs
AI Assistant] Use more BUCKET() examples (#186799)\n\nInstead of using
DATE_TRUNC, use BUCKET in bucketing examples. BUCKET is\r\nmore
appropriate for
bucketing.","sha":"bf315d162a35e74da063f4ec20f8105454d4b0ba"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.14.2 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants