[data view field editor] Allow editing of DataViewLazy #186348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
mattkime
added
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
dej611
approved these changes
Jun 20, 2024
|
/ci |
|
/ci |
botelastic
bot
added
the
ci:project-deploy-observability
|
/ci |
mattkime
force-pushed
the
data_view_mgmt_use_data_view_lazy
branch
from
d677845 to
9f4c569
Compare
|
/ci |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @mattkime |
mattkime
removed
the
ci:project-deploy-observability
kibanamachine
added
v8.15.0
backport:skip
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 24, 2024
## Summary Data view field editor will now allow editing of fields when provided with a DataViewLazy object. Previously it required a DataView object. This change makes it easier for API consumers to move from DataView to DataViewLazy usage. Internally the data view field editor still uses DataView objects since some of the validation code expects a complete field list. The validation code would need to be rewritten to assume incompete field lists. There is the potential for a performance hit when loading a large field list. After the initial load it will be loaded from the browser cache which should be performant. Part of elastic#178926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Data view field editor will now allow editing of fields when provided with a DataViewLazy object. Previously it required a DataView object. This change makes it easier for API consumers to move from DataView to DataViewLazy usage.
Internally the data view field editor still uses DataView objects since some of the validation code expects a complete field list. The validation code would need to be rewritten to assume incompete field lists. There is the potential for a performance hit when loading a large field list. After the initial load it will be loaded from the browser cache which should be performant.
Part of #178926